Last Comment Bug 784975 - New App Menu button hard to see on dark themes
: New App Menu button hard to see on dark themes
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: 17 Branch
: x86_64 Windows 7
: -- trivial with 1 vote (vote)
: Thunderbird 17.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 23:30 PDT by Greg ( Hank1 )
Modified: 2012-08-23 17:38 PDT (History)
7 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Dark Solid Persona - New Menu Button.JPG (21.16 KB, image/jpeg)
2012-08-22 23:30 PDT, Greg ( Hank1 )
no flags Details
without a Persona, (22.77 KB, image/jpeg)
2012-08-22 23:33 PDT, Greg ( Hank1 )
no flags Details
patch (1.15 KB, patch)
2012-08-23 09:13 PDT, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Greg ( Hank1 ) 2012-08-22 23:30:54 PDT
Created attachment 654524 [details]
Dark Solid Persona - New Menu Button.JPG

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120822030558

Steps to reproduce:

installed a dark Persona 


Actual results:

installed a Dark Solid Persona and totally covers up the New Menu button making it hard to see


Expected results:

the New Menu button should be visible with a Dark Persona installed
Comment 1 Greg ( Hank1 ) 2012-08-22 23:33:38 PDT
Created attachment 654526 [details]
without a Persona,
Comment 2 Mike Conley (:mconley) - (Needinfo me!) 2012-08-23 06:40:13 PDT
Richard, can you look at this?
Comment 3 Richard Marti (:Paenglab) 2012-08-23 09:13:06 PDT
Created attachment 654653 [details] [diff] [review]
patch

This patch changes the toolbar-icons to the inverted (white) icons we use on Aero Glass tabbar-toolbar.
Comment 4 Richard Marti (:Paenglab) 2012-08-23 09:18:23 PDT
We have only inverted icons for the main window. Should I open a Bug to add inverted icons in AB and Compozer?
Comment 5 Blake Winton (:bwinton) (:☕️) 2012-08-23 12:46:47 PDT
Comment on attachment 654653 [details] [diff] [review]
patch

This fixes the problem when people choose a dark theme, but not when they go into high-contrast mode, so ui-r-.

Having said that, the code itself seems fine, so r=me.

Thanks,
Blake.
Comment 6 Blake Winton (:bwinton) (:☕️) 2012-08-23 13:32:55 PDT
Comment on attachment 654653 [details] [diff] [review]
patch

So, as noted in IRC, the other buttons are also not nicely visible: https://dl.dropbox.com/u/23792533/screenshots/High-contrast.png and we're fixing that in bug 608792, and this fixes the problem as stated in the bug, so ui-r=me too.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-08-23 17:38:22 PDT
https://hg.mozilla.org/comm-central/rev/26a39d376821

Note You need to log in before you can comment on or make changes to this bug.