The default bug view has changed. See this FAQ.

New App Menu button hard to see on dark themes

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Theme
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Greg ( Hank1 ), Assigned: Paenglab)

Tracking

17 Branch
Thunderbird 17.0
x86_64
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 654524 [details]
Dark Solid Persona - New Menu Button.JPG

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120822030558

Steps to reproduce:

installed a dark Persona 


Actual results:

installed a Dark Solid Persona and totally covers up the New Menu button making it hard to see


Expected results:

the New Menu button should be visible with a Dark Persona installed
(Reporter)

Comment 1

5 years ago
Created attachment 654526 [details]
without a Persona,
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: New Menu button → New App Menu button hard to see on dark themes
Richard, can you look at this?
(Assignee)

Comment 3

5 years ago
Created attachment 654653 [details] [diff] [review]
patch

This patch changes the toolbar-icons to the inverted (white) icons we use on Aero Glass tabbar-toolbar.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #654653 - Flags: ui-review?(bwinton)
Attachment #654653 - Flags: review?(bwinton)
(Assignee)

Comment 4

5 years ago
We have only inverted icons for the main window. Should I open a Bug to add inverted icons in AB and Compozer?
Comment on attachment 654653 [details] [diff] [review]
patch

This fixes the problem when people choose a dark theme, but not when they go into high-contrast mode, so ui-r-.

Having said that, the code itself seems fine, so r=me.

Thanks,
Blake.
Attachment #654653 - Flags: ui-review?(bwinton)
Attachment #654653 - Flags: ui-review-
Attachment #654653 - Flags: review?(bwinton)
Attachment #654653 - Flags: review+
Comment on attachment 654653 [details] [diff] [review]
patch

So, as noted in IRC, the other buttons are also not nicely visible: https://dl.dropbox.com/u/23792533/screenshots/High-contrast.png and we're fixing that in bug 608792, and this fixes the problem as stated in the bug, so ui-r=me too.
Attachment #654653 - Flags: ui-review- → ui-review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/26a39d376821
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.