Last Comment Bug 785026 - get rid of file_util_linux.cc
: get rid of file_util_linux.cc
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: x86_64 FreeBSD
: -- normal (vote)
: mozilla17
Assigned To: Jan Beich
:
Mentors:
Depends on:
Blocks: bsdipc
  Show dependency treegraph
 
Reported: 2012-08-23 03:33 PDT by Jan Beich
Modified: 2012-08-26 13:06 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
merge into file_util_posix.cc (5.47 KB, patch)
2012-08-23 03:48 PDT, Jan Beich
no flags Details | Diff | Splinter Review
merge into file_util_posix.cc, v2 (5.52 KB, patch)
2012-08-23 07:24 PDT, Jan Beich
cjones.bugs: review+
Details | Diff | Splinter Review

Description Jan Beich 2012-08-23 03:33:34 PDT

    
Comment 1 Jan Beich 2012-08-23 03:48:06 PDT
Created attachment 654568 [details] [diff] [review]
merge into file_util_posix.cc

The file is poorly named. Apart from /dev/shm there is nothing linux-specific. And it's even polluted by OS_POSIX from bug 725655 and OS_BSD from bug 753046 (not landed).

This was already done by upstream, not sure when:
https://src.chromium.org/viewvc/chrome/trunk/src/base/file_util_linux.cc?view=markup
https://src.chromium.org/viewvc/chrome/trunk/src/base/file_util_posix.cc?view=markup
Comment 2 Jan Beich 2012-08-23 07:24:04 PDT
Created attachment 654606 [details] [diff] [review]
merge into file_util_posix.cc, v2

forgot ifndef OS_MACOSX
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-08-25 19:33:22 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/f551e52160e0
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-26 13:06:12 PDT
https://hg.mozilla.org/mozilla-central/rev/f551e52160e0

Note You need to log in before you can comment on or make changes to this bug.