The default bug view has changed. See this FAQ.

get rid of file_util_linux.cc

RESOLVED FIXED in mozilla17

Status

()

Core
IPC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

Trunk
mozilla17
x86_64
FreeBSD
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 654568 [details] [diff] [review]
merge into file_util_posix.cc

The file is poorly named. Apart from /dev/shm there is nothing linux-specific. And it's even polluted by OS_POSIX from bug 725655 and OS_BSD from bug 753046 (not landed).

This was already done by upstream, not sure when:
https://src.chromium.org/viewvc/chrome/trunk/src/base/file_util_linux.cc?view=markup
https://src.chromium.org/viewvc/chrome/trunk/src/base/file_util_posix.cc?view=markup
Attachment #654568 - Flags: review?(jones.chris.g)
(Assignee)

Comment 2

5 years ago
Created attachment 654606 [details] [diff] [review]
merge into file_util_posix.cc, v2

forgot ifndef OS_MACOSX
Attachment #654568 - Attachment is obsolete: true
Attachment #654568 - Flags: review?(jones.chris.g)
Attachment #654606 - Flags: review?(jones.chris.g)
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

5 years ago
Blocks: 753046
Attachment #654606 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/f551e52160e0
Assignee: nobody → jbeich
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f551e52160e0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.