785065 - OSX Clang profile guided optimization

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Sam N]

Attachment: Coverage.txt

User Agent: Firefox Nightly (Best Browser is Best)
Build ID: 20120815095439

Steps to reproduce:

I've read reports that Clang doesn't work well with PGO so I applied some changes to some configure.in files, and created a script to relocate gcda files where they chould be


Actual results:

N/A


Expected results:

N/A

Comment 1

[Sam N]

Attachment: Relocates gcda files based on gcno location results from --coverage build

Comment 2

[Sam N]

Attachment: hg diff of my directory

Comment 3

[Sam N]

27" 2011 iMac with 8Gb ram and 2.7 Ghz i5

my .mozconfig is as follows


You may notice that I'm using a non-standard java for my build; this is the binary distributed by oracle (came out like a week ago) and linpack testing showed they were about twice as fast as the apple version.

. $topsrcdir/build/macosx/common
export PATH=/Locals/bin:$PATH
export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_06.jdk/Contents/Home
export DYLD_LIBRARY_PATH=/Locals/lib/
export PKG_CONFIG_PATH="/Volumes/Storage/FirefoxCompile/Libs/lib/pkgconfig/:/opt/local/lib/pkgconfig/"
export CC="clang"
export CXX="clang++"
export CFLAGS="-march=corei7-avx -mtune=corei7-avx -freorder-blocks-and-partition"
export CXXFLAGS="-march=corei7-avx -mtune=corei7-avx -freorder-blocks-and-partition"
export CPPFLAGS="-I/Locals/include -I/Volumes/Storage/FirefoxCompile/Libs/include -I/opt/local/include"
export LDFLAGS="-L/Locals/lib -L/Volumes/Storage/FirefoxCompile/Libs/lib -L/opt/local/lib "
export FORCE_STATIC_LIB=1
export BUILD_STATIC_LIBS=1


mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-ff-dbg
mk_add_options MOZ_MAKE_FLAGS="-j5 -s"
mk_add_options AUTOCONF=autoconf213
mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) $(MOZ_OBJDIR)/_profile/pgo/profileserver.py'
mk_add_options PROFILE_GEN_SCRIPT_PAUSE='$(PYTHON) $(MOZ_OBJDIR)/_profile/pgo/stopmsg.py'
ac_add_options --with-arch=corei7-avx
ac_add_options --disable-debug-symbols
ac_add_options --disable-debug
ac_add_options --disable-jemalloc
ac_add_options --enable-static
ac_add_options --enable-static-libs
ac_add_options --disable-crashreporter
ac_add_options --enable-strip
ac_add_options --enable-install-strip
ac_add_options --disable-tests
ac_add_options --disable-stdcxx-compat
ac_add_options --enable-profile-guided-optimization
ac_add_options --enable-application=browser
ac_add_options --build=x86_64-apple-darwin11.4.0
ac_add_options --host=x86_64-apple-darwin11.4.0
ac_add_options --target=x86_64-apple-darwin11.4.0
ac_add_options --with-system-libvpx
ac_add_options --enable-media-plugins
ac_add_options --enable-default-toolket=cairo-cocoa
ac_add_options --enable-optimize
ac_add_options --enable-media-navigator
ac_add_options --with-system-libevent="/Volumes/Storage/FirefoxCompile/Libs"
ac_add_options --with-pthreads
ac_add_options --enable-llvm-hacks
ac_add_options --enable-egl-xrender-composite
ac_add_options --with-macos-sdk="/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk/"
ac_add_options --enable-system-ffi
ac_add_options --disable-parental-controls

Comment 4

[Sam N]

Comment on attachment 654602 [details]
Coverage.txt

the gcno files output to the correct locations, but the gcda files do not. This file is a reference for where files should go.

Comment 5

[Sam N]

no longer an issue. 

Clang 3.2 supports proper PGO.