Last Comment Bug 785078 - The new menu button is useless on the mac
: The new menu button is useless on the mac
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: 17 Branch
: x86 Mac OS X
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks: TB-AppMenu
  Show dependency treegraph
 
Reported: 2012-08-23 07:52 PDT by Ludovic Hirlimann [:Usul]
Modified: 2012-08-27 12:55 PDT (History)
7 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
WIP patch (1.27 KB, patch)
2012-08-23 13:30 PDT, Richard Marti (:Paenglab)
no flags Details | Diff | Splinter Review
Screenshot (24.96 KB, image/png)
2012-08-23 13:34 PDT, Richard Marti (:Paenglab)
bwinton: feedback+
Details
WIP v2 (2.63 KB, patch)
2012-08-26 14:02 PDT, Richard Marti (:Paenglab)
no flags Details | Diff | Splinter Review
patch v3 (3.57 KB, patch)
2012-08-27 08:38 PDT, Andreas Nilsson (:andreasn)
no flags Details | Diff | Splinter Review
patch (3.68 KB, patch)
2012-08-27 09:38 PDT, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Ludovic Hirlimann [:Usul] 2012-08-23 07:52:17 PDT
The new menu button doesn't bring anything on the mac where the menu bar is still active, maybe we should not show it by default on mac (and te red cross next to exit (while on mac it's quit) makes it horrible).
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-08-23 07:57:45 PDT
Richard / Andreas:

Can I assume that Australis means including the App Menu button on OSX as well?

-Mike
Comment 2 Andreas Nilsson (:andreasn) 2012-08-23 08:11:43 PDT
The menu button was in Shorlander original mockup http://breakingtheegg.tumblr.com/image/18902338028 on mac as well.
Comment 3 Andreas Nilsson (:andreasn) 2012-08-23 08:12:04 PDT
Any idea what Firefox does/will do in this case?
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-08-23 08:14:37 PDT
Stephen?

Any thoughts on whether Australis Firefox will show the ≡ Button by default on Mac (where the menu is always visible)?
Comment 5 Richard Marti (:Paenglab) 2012-08-23 13:30:23 PDT
Created attachment 654769 [details] [diff] [review]
WIP patch

WIP patch to use "Quit" instead of "Exit" under OSX and Linux.
Comment 6 Richard Marti (:Paenglab) 2012-08-23 13:34:53 PDT
Created attachment 654771 [details]
Screenshot

AppMenu screenshot. On the left the actual state, in the middle a proposal with the OSX window close blob and on the right without a icon.

Blake, what do you think should we use? Or do you have an other proposal?
Comment 7 Blake Winton (:bwinton) (:☕️) 2012-08-23 13:50:55 PDT
Comment on attachment 654771 [details]
Screenshot

I think without the icon seems the most mac-like.  Could we also remove the icons for Print and Add-ons?
Comment 8 Nomis101 2012-08-24 12:23:05 PDT
I think the remaining icons (if there are remaining icons) should match the monochrom icons from the menu bar.
Comment 9 Stephen Horlander [:shorlander] 2012-08-24 12:24:44 PDT
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Stephen?
> 
> Any thoughts on whether Australis Firefox will show the ≡ Button by default
> on Mac (where the menu is always visible)?

Yes we plan on showing it in Firefox. However we are redesigning it to not be two paned and it will be a more streamlined version of the full menubar.
Comment 10 Richard Marti (:Paenglab) 2012-08-24 12:30:32 PDT
(In reply to Nomis101 from comment #8)
> I think the remaining icons (if there are remaining icons) should match the
> monochrom icons from the menu bar.

Only the icons for the cut, copy and paste buttons will have icons. I'm waiting for the monochrome icons from Andreas. When I have them I'll attach the full patch.
Comment 11 Richard Marti (:Paenglab) 2012-08-26 14:02:25 PDT
Created attachment 655456 [details] [diff] [review]
WIP v2

WIP patch also removing the icons.
Comment 12 Andreas Nilsson (:andreasn) 2012-08-27 08:38:16 PDT
Created attachment 655597 [details] [diff] [review]
patch v3

Fixes the icons to be monochrome.
Comment 13 Richard Marti (:Paenglab) 2012-08-27 09:38:37 PDT
Created attachment 655617 [details] [diff] [review]
patch

Patch changing "Exit" to "Quit" for OSX and Linux, removing the icons before the menuitems and using monochrome icons for Cut/Copy/Paste (preview of this icons: https://dl.dropbox.com/u/23792533/screenshots/OSX-C-C-P.png).

This fixes the issues. If the button should be shown or not isn't decided yet.
Comment 14 Blake Winton (:bwinton) (:☕️) 2012-08-27 12:35:11 PDT
Comment on attachment 655617 [details] [diff] [review]
patch

Just "Quit", instead of "Quit Thunderbird"?

Either way, ui-r=me.

And r=me, too.

Thanks,
Blake.
Comment 15 Richard Marti (:Paenglab) 2012-08-27 12:43:32 PDT
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #14)
> Comment on attachment 655617 [details] [diff] [review]
> patch
> 
> Just "Quit", instead of "Quit Thunderbird"?

I used only "Quit" to not make the menu wider than it is now.
Comment 16 Ryan VanderMeulen [:RyanVM] 2012-08-27 12:55:07 PDT
https://hg.mozilla.org/comm-central/rev/b10862734205

Note You need to log in before you can comment on or make changes to this bug.