Closed Bug 785078 Opened 7 years ago Closed 7 years ago

The new menu button is useless on the mac

Categories

(Thunderbird :: General, defect)

17 Branch
x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: Usul, Assigned: Paenglab)

References

Details

Attachments

(2 files, 3 obsolete files)

The new menu button doesn't bring anything on the mac where the menu bar is still active, maybe we should not show it by default on mac (and te red cross next to exit (while on mac it's quit) makes it horrible).
Blocks: TB-AppMenu
No longer blocks: 784729
Richard / Andreas:

Can I assume that Australis means including the App Menu button on OSX as well?

-Mike
The menu button was in Shorlander original mockup http://breakingtheegg.tumblr.com/image/18902338028 on mac as well.
Any idea what Firefox does/will do in this case?
Stephen?

Any thoughts on whether Australis Firefox will show the ≡ Button by default on Mac (where the menu is always visible)?
Attached patch WIP patch (obsolete) — Splinter Review
WIP patch to use "Quit" instead of "Exit" under OSX and Linux.
Attached image Screenshot
AppMenu screenshot. On the left the actual state, in the middle a proposal with the OSX window close blob and on the right without a icon.

Blake, what do you think should we use? Or do you have an other proposal?
Attachment #654771 - Flags: feedback?(bwinton)
Comment on attachment 654771 [details]
Screenshot

I think without the icon seems the most mac-like.  Could we also remove the icons for Print and Add-ons?
Attachment #654771 - Flags: feedback?(bwinton) → feedback+
I think the remaining icons (if there are remaining icons) should match the monochrom icons from the menu bar.
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #4)
> Stephen?
> 
> Any thoughts on whether Australis Firefox will show the ≡ Button by default
> on Mac (where the menu is always visible)?

Yes we plan on showing it in Firefox. However we are redesigning it to not be two paned and it will be a more streamlined version of the full menubar.
(In reply to Nomis101 from comment #8)
> I think the remaining icons (if there are remaining icons) should match the
> monochrom icons from the menu bar.

Only the icons for the cut, copy and paste buttons will have icons. I'm waiting for the monochrome icons from Andreas. When I have them I'll attach the full patch.
Attached patch WIP v2 (obsolete) — Splinter Review
WIP patch also removing the icons.
Attachment #654769 - Attachment is obsolete: true
Attached patch patch v3 (obsolete) — Splinter Review
Fixes the icons to be monochrome.
Attachment #655456 - Attachment is obsolete: true
Attached patch patchSplinter Review
Patch changing "Exit" to "Quit" for OSX and Linux, removing the icons before the menuitems and using monochrome icons for Cut/Copy/Paste (preview of this icons: https://dl.dropbox.com/u/23792533/screenshots/OSX-C-C-P.png).

This fixes the issues. If the button should be shown or not isn't decided yet.
Assignee: nobody → richard.marti
Attachment #655597 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #655617 - Flags: ui-review?(bwinton)
Attachment #655617 - Flags: review?(bwinton)
Comment on attachment 655617 [details] [diff] [review]
patch

Just "Quit", instead of "Quit Thunderbird"?

Either way, ui-r=me.

And r=me, too.

Thanks,
Blake.
Attachment #655617 - Flags: ui-review?(bwinton)
Attachment #655617 - Flags: ui-review+
Attachment #655617 - Flags: review?(bwinton)
Attachment #655617 - Flags: review+
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #14)
> Comment on attachment 655617 [details] [diff] [review]
> patch
> 
> Just "Quit", instead of "Quit Thunderbird"?

I used only "Quit" to not make the menu wider than it is now.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b10862734205
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.