Closed
Bug 78517
Opened 24 years ago
Closed 23 years ago
"font-family: -moz-fixed, monospace;" rendered wrong
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
WONTFIX
People
(Reporter: bzbarsky, Assigned: pierre)
References
Details
(Keywords: css-moz, Whiteboard: WONTFIX?)
Changing from PC/Linux to All/All. I have noted this problem on Win2K too.
OS: Linux → All
Hardware: PC → All
The problem with this bug is that the special handling of -moz-fixed in the
Style System is based on the _equality_ of the font-family with -moz-fixed.
i.e., -moz-fixed should always be the only font...
I am facing the same problem over at bug 84398. I am going to adopt the same
semantics: that a font is a generic font if its name is either _equal_
-moz-fixed, monospace, serif, etc...
Suggesting WONTFIX for this bug -- unless there is a better definition.
Cc:ing attinasi since it appeared that he originally checked in that code as
part of bug 31816 and bug 40340. There has been some changes since then however.
FirstExistingFont() isn't used anymore in the current code, I guess for perf
reasons since the GFX font subsystem can skip pass inexisting fonts later.
Below is an excerpt of the original patch attached on bug 40340.
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17394
+ // find the correct font if we are usingDocumentFonts OR we are
overriding for XUL
+ // MJA: bug 31816
+ PRBool fontFaceOK = PR_TRUE;
+ PRBool isMozFixed =
font->mFont.name.EqualsIgnoreCase("-moz-fixed");
+ if ((chromeOverride || useDocumentFonts)) {
+ fontFaceOK = (NS_SUCCEEDED(dc->FirstExistingFont(font->mFont,
face)));
+ }
+ if (!fontFaceOK || !(chromeOverride || useDocumentFonts)) {
+ // now set to defaults
font->mFont.name = defaultFont.name;
- font->mFixedFont.name = defaultFixedFont.name;
+ font->mFixedFont.name= defaultFixedFont.name;
+ }
Comment 4•24 years ago
|
||
I am really not too pleased with the way -moz-fixed is used (can you spell
-moz-HACK?), however I think that as a proprietary and special-case mechanism it
should not matter if author rules that use -moz-fixed are treated differently
than they would be with 'normal' fonts. I agree with rbs that we should probably
not fix this. In other words, we should leave the requirement that -moz-fixed be
the only font specified if it is to be applied.
Assignee | ||
Comment 6•23 years ago
|
||
Agreed: -moz-fixed is an internal hack. WontFix
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•