Closed
Bug 785238
Opened 12 years ago
Closed 12 years ago
Should catch AgentError inside devicemanagerSUT's getInfo
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: wlach, Assigned: jmaher)
Details
Attachments
(1 file)
|
686 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
As seen here: http://hg.mozilla.org/mozilla-central/file/3c39442f9f19/build/mobile/devicemanagerSUT.py#l937 getInfo runs runCmd, which can raise AgentError. We should catch this exception and return None in this case.
|
Reporter | |
Comment 1•12 years ago
|
||
CCing relevant people
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 654998 [details] [diff] [review] catch agent error in getinfo (1.0) LGTM
Attachment #654998 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
hello inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/b229d9eaa843
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b229d9eaa843
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•