785278 - Ensure that partial updates will not override update blocks

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Alex Keybl [:akeybl]]

Ensure that partial updates will not override the update block to FF17 for 10.5 users and the update block to FF13 for XP SP1 users.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

We should certainly test but I think this will be OK. The pseudocode is:

* look up complete update
* look up partial update
* check if the version offer is supported for the OS making the query

http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/index.php#315
http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/patch.class.php#731
http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/config-dist.php#212

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Manually created URLs making use of the existing block of OSX 10.4 on FF4 and higher.

10.6.8, FF 15.0b5 (partial+complete):
https://aus3.mozilla.org/update/3/Firefox/15.0/20120814224555/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%2010.8.0/default/default/update.xml

10.6.8, FF 15.0b4 (partial+complete):
https://aus3.mozilla.org/update/1/Firefox/15.0/20120808131812/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%2010.8.0/default/default/update.xml

10.6.8, FF 15.0b3 (complete):
https://aus3.mozilla.org/update/1/Firefox/15.0/20120731150526/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%2010.8.0/default/default/update.xml

10.4.2, FF 15.0b5 (no update):
https://aus3.mozilla.org/update/3/Firefox/15.0/20120814224555/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%208.2.0/default/default/update.xml

10.4.2, FF 15.0b4 (no update):
https://aus3.mozilla.org/update/1/Firefox/15.0/20120808131812/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%208.2.0/default/default/update.xml

10.4.2, FF 15.0b3 (no update):
https://aus3.mozilla.org/update/1/Firefox/15.0/20120731150526/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%208.2.0/default/default/update.xml

This is a little synthetic, so happy to reverify or ask QA once we get FF17 onto beta.

Comment 3

[[e-mail] (:bhearsum)]

Thanks for your testing Nick! I'll keep this in the triage queue until 17 is in beta, and we can retest.

Comment 4

[[e-mail] (:bhearsum)]

I just retested by updating the URLs in comment #2 to be Darwin 9, none of the following to an update:
https://aus3.mozilla.org/update/1/Firefox/15.0/20120731150526/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%209/default/default/update.xml
https://aus3.mozilla.org/update/1/Firefox/15.0/20120808131812/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%209/default/default/update.xml
https://aus3.mozilla.org/update/3/Firefox/15.0/20120814224555/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/beta/Darwin%209/default/default/update.xml

Pretty sure that means this is now verified for 17.