785321 - Replace PRUptrdiff with uintptr_t, prtdiff_t or etc

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Makoto Kato [:m_kato]]

bug 579517 is fixed, but Gecko still uses PRUptrdiff.  We should replace it with uintptr_t, ptrdiff_t or etc.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

See bug 478190 why we use PRUptrdiff for PtrBits.

Comment 3

[(no longer active)]

Comment on attachment 654947 [details] [diff] [review]
fix

Review of attachment 654947 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/qcms/qcmstypes.h
@@ +28,5 @@
>  #ifdef __OS2__
>  /* OS/2's stdlib typdefs uintptr_t. So we'll just include that so we don't collide */
>  #include <stdlib.h>
>  #elif !defined(__intptr_t_defined) && !defined(_UINTPTR_T_DEFINED)
> +typedef unsigned long uintptr_t;

I'm not very sure if this change is correct because the size of long is not always the same as the size of a pointer.  Also the code above it doesn't make much sense to me.  I've asked Jeff to review this part.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ff74108db1d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ff74108db1d

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 654947 [details] [diff] [review]
fix

Review of attachment 654947 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ycbcr/convert.patch
@@ +321,5 @@
>     // after the end for SSE2 version.
>     uint8 yuvbuf[16 + kFilterBufferSize * 3 + 16];
>     uint8* ybuf =
>  -      reinterpret_cast<uint8*>(reinterpret_cast<uintptr_t>(yuvbuf + 15) & ~15);
> ++      reinterpret_cast<uint8*>(reinterpret_cast<uintptr_t>(yuvbuf + 15) & ~15);

I'm not missing anything here, am I?

Comment 7

[(no longer active)]

(In reply to :Ms2ger from comment #6)
> Comment on attachment 654947 [details] [diff] [review]
> fix
> 
> Review of attachment 654947 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/ycbcr/convert.patch
> @@ +321,5 @@
> >     // after the end for SSE2 version.
> >     uint8 yuvbuf[16 + kFilterBufferSize * 3 + 16];
> >     uint8* ybuf =
> >  -      reinterpret_cast<uint8*>(reinterpret_cast<uintptr_t>(yuvbuf + 15) & ~15);
> > ++      reinterpret_cast<uint8*>(reinterpret_cast<uintptr_t>(yuvbuf + 15) & ~15);
> 
> I'm not missing anything here, am I?

It is not at all clear what you're asking here!

Comment 8

[Masatoshi Kimura [:emk]]

I guess he's asking why exactly the same line appears in the diff.
> -      reinterpret_cast<uint8*>(reinterpret_cast<uintptr_t>(yuvbuf + 15) & ~15);
>-+      reinterpret_cast<uint8*>(reinterpret_cast<PRUptrdiff>(yuvbuf + 15) & ~15);
>++      reinterpret_cast<uint8*>(reinterpret_cast<uintptr_t>(yuvbuf + 15) & ~15);
This diff line itself can be removed from convert.patch.

Comment 9

[(no longer active)]

Ah, I see!  I removed the entire hunk from convert.patch:

https://hg.mozilla.org/integration/mozilla-inbound/rev/14eac84d5ce6

Comment 10

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/14eac84d5ce6