Last Comment Bug 785415 - WebConsoleUtils: getInnerWindowById is unused and broken
: WebConsoleUtils: getInnerWindowById is unused and broken
Status: RESOLVED FIXED
[mentor=jdm][lang=js]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: Firefox 17
Assigned To: Abhishek Potnis [:avp]
:
: Brian Grinstead [:bgrins]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-24 09:20 PDT by Josh Matthews [:jdm] (on vacation until Dec 5)
Modified: 2012-08-27 03:41 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
removed getInnerWindowId function from WebConsoleUtils.jsm (1.55 KB, patch)
2012-08-25 19:26 PDT, Abhishek Potnis [:avp]
mihai.sucan: review+
josh: feedback+
Details | Diff | Splinter Review

Description Josh Matthews [:jdm] (on vacation until Dec 5) 2012-08-24 09:20:59 PDT
It uses a nonexistent method on nsIDOMWindowUtils. Luckily, it doesn't appear to have any callers. Let's get rid of it from http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/WebConsoleUtils.jsm .
Comment 1 Abhishek Potnis [:avp] 2012-08-25 09:22:26 PDT
Hi Josh,

I would like to work on this bug. Could you please guide me on getting started with it.....

Thanks.
Comment 2 Josh Matthews [:jdm] (on vacation until Dec 5) 2012-08-25 17:35:02 PDT
Abhishek, is anything from my initial comment unclear?
Comment 3 Abhishek Potnis [:avp] 2012-08-25 19:26:55 PDT
Created attachment 655392 [details] [diff] [review]
removed getInnerWindowId function from WebConsoleUtils.jsm
Comment 4 Josh Matthews [:jdm] (on vacation until Dec 5) 2012-08-25 19:28:40 PDT
Comment on attachment 655392 [details] [diff] [review]
removed getInnerWindowId function from WebConsoleUtils.jsm

Looks ok to me. Over the the devtools folks!
Comment 5 Mihai Sucan [:msucan] 2012-08-26 02:44:16 PDT
Comment on attachment 655392 [details] [diff] [review]
removed getInnerWindowId function from WebConsoleUtils.jsm

Thank you!
Comment 6 Josh Matthews [:jdm] (on vacation until Dec 5) 2012-08-26 12:35:19 PDT
Abhishek, I'm going to push this patch and set the author and commit message properly. However, in the future could you follow the steps at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in so that other people can push your patches without any changes?
Comment 7 Josh Matthews [:jdm] (on vacation until Dec 5) 2012-08-26 12:36:37 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5d691072fd6
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-26 19:25:39 PDT
https://hg.mozilla.org/mozilla-central/rev/a5d691072fd6
Comment 9 Abhishek Potnis [:avp] 2012-08-27 03:41:58 PDT
Thanks a lot Josh ! I will surely follow the steps suggested by you while submitting a patch from now one.....thanks again..... :)

Note You need to log in before you can comment on or make changes to this bug.