Closed Bug 785415 Opened 8 years ago Closed 8 years ago
Console Utils: get Inner Window By Id is unused and broken
It uses a nonexistent method on nsIDOMWindowUtils. Luckily, it doesn't appear to have any callers. Let's get rid of it from http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/WebConsoleUtils.jsm .
Hi Josh, I would like to work on this bug. Could you please guide me on getting started with it..... Thanks.
Abhishek, is anything from my initial comment unclear?
Comment on attachment 655392 [details] [diff] [review] removed getInnerWindowId function from WebConsoleUtils.jsm Looks ok to me. Over the the devtools folks!
Comment on attachment 655392 [details] [diff] [review] removed getInnerWindowId function from WebConsoleUtils.jsm Thank you!
Attachment #655392 - Flags: review?(mihai.sucan) → review+
Abhishek, I'm going to push this patch and set the author and commit message properly. However, in the future could you follow the steps at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in so that other people can push your patches without any changes?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Thanks a lot Josh ! I will surely follow the steps suggested by you while submitting a patch from now one.....thanks again..... :)
You need to log in before you can comment on or make changes to this bug.