WebConsoleUtils: getInnerWindowById is unused and broken

RESOLVED FIXED in Firefox 17

Status

RESOLVED FIXED
7 years ago
8 months ago

People

(Reporter: jdm, Assigned: avp)

Tracking

Trunk
Firefox 17
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jdm][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
It uses a nonexistent method on nsIDOMWindowUtils. Luckily, it doesn't appear to have any callers. Let's get rid of it from http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/WebConsoleUtils.jsm .
(Assignee)

Comment 1

7 years ago
Hi Josh,

I would like to work on this bug. Could you please guide me on getting started with it.....

Thanks.
(Reporter)

Comment 2

7 years ago
Abhishek, is anything from my initial comment unclear?
(Assignee)

Comment 3

7 years ago
Created attachment 655392 [details] [diff] [review]
removed getInnerWindowId function from WebConsoleUtils.jsm
Attachment #655392 - Flags: feedback?(josh)
(Reporter)

Comment 4

7 years ago
Comment on attachment 655392 [details] [diff] [review]
removed getInnerWindowId function from WebConsoleUtils.jsm

Looks ok to me. Over the the devtools folks!
Attachment #655392 - Flags: review?(mihai.sucan)
Attachment #655392 - Flags: feedback?(josh)
Attachment #655392 - Flags: feedback+
Comment on attachment 655392 [details] [diff] [review]
removed getInnerWindowId function from WebConsoleUtils.jsm

Thank you!
Attachment #655392 - Flags: review?(mihai.sucan) → review+
(Reporter)

Comment 6

7 years ago
Abhishek, I'm going to push this patch and set the author and commit message properly. However, in the future could you follow the steps at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in so that other people can push your patches without any changes?
(Reporter)

Updated

7 years ago
Assignee: nobody → abhishekp.bugzilla
https://hg.mozilla.org/mozilla-central/rev/a5d691072fd6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
(Assignee)

Comment 9

7 years ago
Thanks a lot Josh ! I will surely follow the steps suggested by you while submitting a patch from now one.....thanks again..... :)

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.