785441 - Gecko assertion failures when using Stagefright decoding: "ScaleYCbCrToRGB565 source image unpadded?"

Status: RESOLVED INACTIVE

(Core :: Audio/Video: Playback, defect)

Description

[Chris Peterson [:cpeterson]]

When using Stagefright's hardware or software decoders in a debug build of Firefox, I get many assertion failures from our color conversion code:

I/Gecko   (16185): ###!!! ASSERTION: ScaleYCbCrToRGB565 source image unpadded?: 'abs(y_pitch) >= abs(source_width)+16', file /Users/cpeterson/Code/mozilla/central/gfx/ycbcr/ycbcr_to_rgb565.cpp, line 338
I/Gecko   (16185): ###!!! ASSERTION: ScaleYCbCrToRGB565 source image unpadded?: 'abs(y_pitch) >= abs(source_width)+16', file /Users/cpeterson/Code/mozilla/central/gfx/ycbcr/ycbcr_to_rgb565.cpp, line 338

Comment 1

[Chris Peterson [:cpeterson]]

I believe these assertion failures are fallout from gralloc bug 767480.

Comment 2

[Maire Reavy [:mreavy]]

It looks like this may be fixed by bug 785339.  Can we get this retested?  Thanks.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Kevin, the qawanted is for Maire's comment 2

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Any specific device or video that this needs to be tested on? Besides an ICS or JB device.

Comment 5

[Maire Reavy [:mreavy]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #4)
> Any specific device or video that this needs to be tested on? Besides an ICS
> or JB device.

cpeterson -- what device did you see these assertions on?

Comment 6

[Chris Peterson [:cpeterson]]

I think I repro'd the problem on my Galaxy S III, but not on my Galaxy Nexus.

Comment 7

[Nils Ohlmeier [:drno]]

Mass closing do to inactivity.
Feel free to re-open if still needed.