Closed Bug 78545 Opened 23 years ago Closed 23 years ago

Tinderbox 'Show checkins' URLs load in the iframe, not the main window

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: mscott)

References

Details

(Keywords: regression) 

For a while now, clicking on someone's name in the Guilty column on Tinderbox, 
then choosing 'Check-ins in the last 24 hours' in the resulting floating iframe 
loads the resulting page into that iframe, rather than the main browser window.

This seems like a url targetting issue.
Severity: normal → major
Keywords: mozilla0.9.1, nsCatFood, regression
not sure the status on moz0.9, but how soon could this get fixed? pretty bad
that Show Checkins isn't working anymore.
chatted w/mcafee --this likely isn't a tbox source issue, but an iframe issue.
he's seen it for some time on the commercial tbox. but, oddly, i cannot repro
this using 6.01 [linux, both modern and classic are fine, so not themes here
either].
mcafee sees this in gtkEmbed, so punting over to layout.
Assignee: pchen → karnaze
Component: XP Apps → Layout
QA Contact: sairuh → petersen
Hrmm, I think this is mscott or someone like danm. We're loading the URL in the 
wrong docShell, which is outside of layout.

per sfraser, over to mscott for a peek.
Assignee: karnaze → mscott
This worksforme with 050209 0_9_BRANCH build on Mac OS 9.  It also seems fine on
win32 and linuc 0_9_BRANCH builds.  I tested by loading tinderbox and clicking
on a name in the guilty column.  An iframe popup came up and I clicked each of
the checkin links.  All of them resulted in the bonsai CVS Checkins page loading
in the browser window and not the iframe.  Perhaps this regressed after the
branch was cut.
OS: Mac System 8.5 → All
I think this should go to rpotts.
Blocks: 65777
I believe this was fixed yesterday. Using today's latest release builds this is
working for me. I just tested on windows. I'll try Mac next. 
yes this looks fixed on linux, too.

marking fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.