Closed Bug 785463 Opened 8 years ago Closed 8 years ago

Tweak PurpleBuffer Block size

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files)

Attached patch patchSplinter Review
Since the size of the purple buffer has changed, we should tweak the block size.
We could also increase the size of block so that we wouldn't have to allocate
stuff so often, and hopefully cache locality is better.
Attachment #655085 - Flags: review?(continuation)
Comment on attachment 655085 [details] [diff] [review]
patch

Review of attachment 655085 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsCycleCollector.cpp
@@ +703,5 @@
>  {
>  private:
>      struct Block {
>          Block *mNext;
> +         // Try to match the size of a jemalloc bucket size.

remove the second "size" from the comment
Attachment #655085 - Flags: review?(continuation) → review+
Attached patch patchSplinter Review
https://hg.mozilla.org/mozilla-central/rev/45204dc49ac2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.