The default bug view has changed. See this FAQ.

Tweak PurpleBuffer Block size

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 655085 [details] [diff] [review]
patch

Since the size of the purple buffer has changed, we should tweak the block size.
We could also increase the size of block so that we wouldn't have to allocate
stuff so often, and hopefully cache locality is better.
Attachment #655085 - Flags: review?(continuation)
Comment on attachment 655085 [details] [diff] [review]
patch

Review of attachment 655085 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsCycleCollector.cpp
@@ +703,5 @@
>  {
>  private:
>      struct Block {
>          Block *mNext;
> +         // Try to match the size of a jemalloc bucket size.

remove the second "size" from the comment
Attachment #655085 - Flags: review?(continuation) → review+
Created attachment 655092 [details] [diff] [review]
patch
https://hg.mozilla.org/mozilla-central/rev/45204dc49ac2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.