[AccessFu] only instantiate a11y engine on AccessFu._enable()

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Some globals have us instantiating a11y early (understatement).
(Assignee)

Comment 1

5 years ago
Created attachment 655162 [details] [diff] [review]
Add accessible retreival service to utils, and remove it as global from modules.

Didn't test this much. But I think this is good, at least before uplift.
Attachment #655162 - Flags: review?(dbolter)
Comment on attachment 655162 [details] [diff] [review]
Add accessible retreival service to utils, and remove it as global from modules.

Review of attachment 655162 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't apply and test this patch as I'm assuming you did. I assume grepping for global gAccRetrieval declarations (you deleted the 3 I found), and usage now results in the empty set.

I'm assuming there is no sign of engine instantiation anymore.

Thanks for jumping on this (yoikes).

r=me

::: accessible/src/jsat/Utils.jsm
@@ +22,5 @@
>  
> +  get AccRetrieval() {
> +    if (!this._AccRetrieval)
> +      this._AccRetrieval = Cc['@mozilla.org/accessibleRetrieval;1'].
> +          getService(Ci.nsIAccessibleRetrieval);

nit: Since this spans two lines I'd like to see {}'s or a space before the return.
Attachment #655162 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
Addressed nits

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6192cb67e8c
(Assignee)

Updated

5 years ago
Assignee: nobody → eitan
https://hg.mozilla.org/mozilla-central/rev/d6192cb67e8c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.