The default bug view has changed. See this FAQ.

Use also inverted icons for AB and Compozer with dark Personas

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: andreasn)

Tracking

unspecified
Thunderbird 18.0
All
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
With Bug 784975 the main window uses inverted icons with dark personas. AB and Compozer have actually no inverted icons. Dark icons on dark personas don't look so good.
(Reporter)

Comment 1

5 years ago
Andreas, please can you create inverted icons for AB and Compozer?
(Assignee)

Comment 2

5 years ago
Created attachment 655624 [details] [diff] [review]
inverted toolbar icons

Here is the graphics.
(Assignee)

Comment 3

5 years ago
Created attachment 655647 [details] [diff] [review]
graphics + css
(Assignee)

Comment 4

5 years ago
Created attachment 655656 [details] [diff] [review]
graphics + css

Fixed the security icon too.
Attachment #655647 - Attachment is obsolete: true
Attachment #655656 - Flags: ui-review?(bwinton)
Attachment #655656 - Flags: review?(richard.marti)
(Assignee)

Comment 5

5 years ago
Created attachment 655658 [details]
screenshot of compose window with patch
(Assignee)

Comment 6

5 years ago
Created attachment 655659 [details]
screenshot of address book window
(Reporter)

Comment 7

5 years ago
Comment on attachment 655656 [details] [diff] [review]
graphics + css

Review of attachment 655656 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
r+ with two nits fixed:

::: mail/themes/qute/mail/addrbook/addressbook-aero.css
@@ +243,5 @@
>    }
>  }
>  
> +#ab-bar2:-moz-lwtheme-brighttext .toolbarbutton-1 {
> +   list-style-image: url("chrome://messenger/skin/addressbook/icons/addressbook-toolbar-inverted.png");

One white space to much.

::: mail/themes/qute/mail/compose/messengercompose-aero.css
@@ +289,5 @@
>    }
>  }
>  
> +#composeToolbar2:-moz-lwtheme-brighttext .toolbarbutton-1 {
> +   list-style-image: url("chrome://messenger/skin/messengercompose/compose-toolbar-inverted.png");

Also here three instead of two white spaces.
Attachment #655656 - Flags: review?(richard.marti) → review+
(Assignee)

Comment 8

5 years ago
Created attachment 655704 [details] [diff] [review]
graphics + css

Updated patch to address Richards nits. Carrying over review+
Attachment #655656 - Attachment is obsolete: true
Attachment #655656 - Flags: ui-review?(bwinton)
Attachment #655704 - Flags: ui-review?(bwinton)
Attachment #655704 - Flags: review+
Comment on attachment 655704 [details] [diff] [review]
graphics + css

ui-r=me, based on the screenshots…

Thanks,
Blake.
Attachment #655704 - Flags: ui-review?(bwinton) → ui-review+
(Reporter)

Comment 10

5 years ago
I set checkin-needed as the patch has ui-r+ and r+
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Assignee: nobody → nisses.mail
https://hg.mozilla.org/comm-central/rev/d7e8c7ff579b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.