Remove JS_MakeStringImmutable

RESOLVED FIXED in mozilla18

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 655177 [details] [diff] [review]
v0

I don't think this is needed anymore.  The one user calls GetStringCharsZ immediately afterwards, which has the same side-effect.
Attachment #655177 - Flags: review?(luke)

Updated

5 years ago
Attachment #655177 - Flags: review?(luke) → review+
(Assignee)

Comment 1

5 years ago
Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=f82b36d59f5f

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2954b2a61cfa
https://hg.mozilla.org/mozilla-central/rev/2954b2a61cfa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 655177 [details] [diff] [review]
v0

Review of attachment 655177 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCVariant.cpp
@@ +288,1 @@
>              return false;

Can toString() really return null?
(Assignee)

Comment 4

5 years ago
(In reply to :Ms2ger from comment #3)
> Can toString() really return null?

Not in this instance.  File a follow-up bug?
You need to log in before you can comment on or make changes to this bug.