Last Comment Bug 785524 - Remove JS_MakeStringImmutable
: Remove JS_MakeStringImmutable
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla18
Assigned To: Terrence Cole [:terrence]
: general
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-08-24 15:02 PDT by Terrence Cole [:terrence]
Modified: 2012-08-28 10:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v0 (4.80 KB, patch)
2012-08-24 15:02 PDT, Terrence Cole [:terrence]
luke: review+
Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2012-08-24 15:02:57 PDT
Created attachment 655177 [details] [diff] [review]

I don't think this is needed anymore.  The one user calls GetStringCharsZ immediately afterwards, which has the same side-effect.
Comment 2 User image Ryan VanderMeulen [:RyanVM] 2012-08-27 19:18:13 PDT
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2012-08-28 01:41:15 PDT
Comment on attachment 655177 [details] [diff] [review]

Review of attachment 655177 [details] [diff] [review]:

::: js/xpconnect/src/XPCVariant.cpp
@@ +288,1 @@
>              return false;

Can toString() really return null?
Comment 4 User image Terrence Cole [:terrence] 2012-08-28 10:08:06 PDT
(In reply to :Ms2ger from comment #3)
> Can toString() really return null?

Not in this instance.  File a follow-up bug?

Note You need to log in before you can comment on or make changes to this bug.