Last Comment Bug 785524 - Remove JS_MakeStringImmutable
: Remove JS_MakeStringImmutable
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla18
Assigned To: Terrence Cole [:terrence]
: general
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-24 15:02 PDT by Terrence Cole [:terrence]
Modified: 2012-08-28 10:08 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (4.80 KB, patch)
2012-08-24 15:02 PDT, Terrence Cole [:terrence]
luke: review+
Details | Diff | Review

Description Terrence Cole [:terrence] 2012-08-24 15:02:57 PDT
Created attachment 655177 [details] [diff] [review]
v0

I don't think this is needed anymore.  The one user calls GetStringCharsZ immediately afterwards, which has the same side-effect.
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-08-27 19:18:13 PDT
https://hg.mozilla.org/mozilla-central/rev/2954b2a61cfa
Comment 3 :Ms2ger 2012-08-28 01:41:15 PDT
Comment on attachment 655177 [details] [diff] [review]
v0

Review of attachment 655177 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCVariant.cpp
@@ +288,1 @@
>              return false;

Can toString() really return null?
Comment 4 Terrence Cole [:terrence] 2012-08-28 10:08:06 PDT
(In reply to :Ms2ger from comment #3)
> Can toString() really return null?

Not in this instance.  File a follow-up bug?

Note You need to log in before you can comment on or make changes to this bug.