785638 - use yasm(1) on ELF platforms by default

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Jan Beich]

Attachment: vp8 asm

Tested on FreeBSD x86_64. Should also work on GNU/kFreeBSD, NetBSD and DragonFly.

Comment 2

[Jan Beich]

Attachment: libjpeg-turbo asm

ditto

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=3eefa652b5f9

https://hg.mozilla.org/integration/mozilla-inbound/rev/8eb3be6ada0e
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8ac3833d2a1

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8eb3be6ada0e
https://hg.mozilla.org/mozilla-central/rev/d8ac3833d2a1

Comment 5

[Landry Breuil (:gaston)]

This of course broke OpenBSD. We have yasm 1.2.0, but configure now bails out : 

checking for Yasm assembler... checking for yasm... yasm
configure: error: Yasm 1.1 or greater is required to build with libjpeg-turbo's optimized JPEG decoding routines, but you appear to have version ..  Upgrade to the newest
 version or configure with --disable-libjpeg-turbo to use the pure C JPEG decoder.  See https://developer.mozilla.org/en/YASM for more details.

Guess the sed regex doesnt like our sed.. or should it use gsed ?

Comment 6

[Jan Beich]

Attachment: simplify, tested on yasm 0.5.0 and 1.2.0

(In reply to Landry Breuil (:gaston) from comment #5)
> This of course broke OpenBSD. We have yasm 1.2.0

1.2.0 consists of 3 digits while _YASM_VER_FILTER wants 4 digits. (d)ash and bash just ignores the bogus regexp

    $ test '' -lt 1; echo "Exit $?"
    test: : bad number
    Exit 2

while pdksh and zsh choke on it

  $ test '' -lt 1; echo "Exit $?"
  Exit 0

and it's not so clear on OpenBSD

  $ /bin/test '' -lt 1
  test: : out of range
  Exit 2

Comment 7

[Landry Breuil (:gaston)]

Comment on attachment 656297 [details] [diff] [review]
simplify, tested on yasm 0.5.0 and 1.2.0

Configure passes fine for me with this fix, thanks !

Comment 8

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a7b6c266752

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a7b6c266752