Closed Bug 785715 Opened 7 years ago Closed 7 years ago

GCLI "screenshot" command should refer to "selector" instead of "node"

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: tetsuharu, Assigned: tetsuharu)

Details

Attachments

(1 file)

At Bug 777001, GCLI "inspect" command referred "selector" instead of "node".
So we change "screenshot" command with same reason.
Assignee: nobody → saneyuki.s.snyk
Status: NEW → ASSIGNED
Try run for 5cc259b23173 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=5cc259b23173
Results (out of 1 total builds):
    exception: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/saneyuki.snyk@gmail.com-5cc259b23173
Attached patch patchSplinter Review
I tried on this patch, it did not fail.
Attachment #655941 - Flags: review?(jwalker)
Try run for 53a67bcd571f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=53a67bcd571f
Results (out of 4 total builds):
    success: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/saneyuki.snyk@gmail.com-53a67bcd571f
Attachment #655941 - Flags: review?(jwalker) → review+
Thanks. Will add to my queue.
Sorry that last comment - ignore. this patch was not part of that try run.
https://tbpl.mozilla.org/?tree=Fx-Team&rev=aaa9837d68b3
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
https://hg.mozilla.org/mozilla-central/rev/1349f5b8385a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.