785729 - Webservice Bug.fields (_legal_field_values) should return isactive for versions, components and milestones

Status: RESOLVED FIXED

(Bugzilla :: WebService, enhancement)

Description

[Frank Becker]

There is no way for clients like Mylyn to get the information if a version, components or milestones is retired(bug#77193).

Comment 1

[Frank Becker]

Attachment: patch V1

Comment 2

[Frédéric Buclin]

Comment on attachment 655437 [details] [diff] [review]
patch V1

You must document 'isactive'. Also, use is_active instead, for consistency with other fields.

Comment 3

[Frank Becker]

Attachment: patch V2

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 655447 [details] [diff] [review]
patch V2

Review of attachment 655447 [details] [diff] [review]:
-----------------------------------------------------------------

Minor changes that can be made on checkin. Otherwise looks fine and works as expected. r=dkl

::: Bugzilla/WebService/Bug.pm
@@ +167,4 @@
>                      sort_key => $self->type('int', $sortkey),
>                      sortkey  => $self->type('int', $sortkey), # deprecated
>                      visibility_values => [$self->type('string', $product_name)],
> +                    is_active         => $self->type('boolean', $value->is_active()),

nit: $value->is_active (no parens)

@@ +1193,5 @@
>  
> +=item C<is_active>
> +
> +C<boolean> True when the version, target_milestone or component is active,
> +false when the element is retired.

C<boolean> True when the value for version, target_milestone, or component is active, false when the value is not active.

Comment 5

[Frédéric Buclin]

Comment on attachment 655447 [details] [diff] [review]
patch V2

>+=item C<is_active>
>+
>+C<boolean> True when the version, target_milestone or component is active,
>+false when the element is retired.

It should be made clearer that is_active is defined for product-specific fields only. dkl, please reword this on checkin.

Comment 6

[Frédéric Buclin]

dkl: also add to the History section that is_active exists only since 4.4.

Comment 7

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4
modified Bugzilla/WebService/Bug.pm
Committed revision 8375.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/WebService/Bug.pm
Committed revision 8377.

Comment 8

[Frédéric Buclin]

Added to the relnotes for 4.4.