785759 - Allow adding CSS stylesheets to contentURL in panel API

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[WM]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.81 Safari/537.1

Steps to reproduce:

Just like this issue：
Allow adding CSS stylesheets to page with page-mod API
https://bugzilla.mozilla.org/show_bug.cgi?id=634764

Could we also add `contentStyle` and `contentStyleFile` to PageMod's options？

This would be very useful when contentURL is loaded with remote content

Comment 1

[WM]

typo：
Could we also add `contentStyle` and `contentStyleFile` to Panel's options？

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

We're working in improving `contentStyle*` (see: https://github.com/mozilla/addon-sdk/wiki/contentStyle-issues); as soon as the platform bug 737003 will land, we will able to add `contentStyle*` properties to `tabs` and `panels` as well.

Comment 3

[WM]

So now, I think that panel should be able to have a contentStyle property to achieve this.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: pull/1446

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8397267 [details] [review]
pull/1446

some nits, looks good!

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/267e9de51fb5a6b53104304ea01290d6f8ec2d8a
Bug 785759 - Allow adding CSS stylesheets to contentURL in panel API

https://github.com/mozilla/addon-sdk/commit/1776402b8755f979e4963d48c56d061554464e7f
Merge pull request #1446 from ZER0/panel-css/785759

fix Bug 785759 - Allow adding CSS stylesheets to contentURL in panel API r=@jsantell