Allow adding CSS stylesheets to contentURL in panel API

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: wandererm, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.81 Safari/537.1

Steps to reproduce:

Just like this issue:
Allow adding CSS stylesheets to page with page-mod API
https://bugzilla.mozilla.org/show_bug.cgi?id=634764

Could we also add `contentStyle` and `contentStyleFile` to PageMod's options?

This would be very useful when contentURL is loaded with remote content
(Reporter)

Comment 1

6 years ago
typo:
Could we also add `contentStyle` and `contentStyleFile` to Panel's options?

Updated

6 years ago
Priority: -- → P2
We're working in improving `contentStyle*` (see: https://github.com/mozilla/addon-sdk/wiki/contentStyle-issues); as soon as the platform bug 737003 will land, we will able to add `contentStyle*` properties to `tabs` and `panels` as well.
Depends on: 737003
Depends on: 837494
(Reporter)

Comment 3

5 years ago
So now, I think that panel should be able to have a contentStyle property to achieve this.
Created attachment 8397267 [details] [review]
pull/1446
Attachment #8397267 - Flags: review?(jsantell)
Comment on attachment 8397267 [details] [review]
pull/1446

some nits, looks good!
Attachment #8397267 - Flags: review?(jsantell) → review+

Comment 6

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/267e9de51fb5a6b53104304ea01290d6f8ec2d8a
Bug 785759 - Allow adding CSS stylesheets to contentURL in panel API

https://github.com/mozilla/addon-sdk/commit/1776402b8755f979e4963d48c56d061554464e7f
Merge pull request #1446 from ZER0/panel-css/785759

fix Bug 785759 - Allow adding CSS stylesheets to contentURL in panel API r=@jsantell

Updated

5 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.