Segmentation fault when calling %ThrowError for message with three arguments

RESOLVED FIXED in mozilla18

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mozillabugs, Assigned: mozillabugs)

Tracking

(Blocks: 1 bug)

Other Branch
mozilla18
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Using the %ThrowError intrinsic from self-hosted code causes a segmentation fault if formatting a message with three arguments.
(Assignee)

Comment 1

7 years ago
Created attachment 655534 [details] [diff] [review]
proposed patch
(Assignee)

Comment 2

7 years ago
Created attachment 656309 [details]
test case (not to be checked in)

After building with this patch, use the shell to run

    [].testThrowError();

This should throw an exception with the strings "arg 1", "arg 2", "arg 3" embedded in the message. It should not cause a segmentation fault.
Assignee: general → mozillabugs
Status: NEW → ASSIGNED
(Assignee)

Comment 3

7 years ago
Created attachment 656312 [details] [diff] [review]
proposed patch

Rebased to current mozilla-central, which did change the changed line (from int to unsigned), and improved the commit message.
Attachment #655534 - Attachment is obsolete: true
Attachment #656312 - Flags: review?(jorendorff)
Comment on attachment 656312 [details] [diff] [review]
proposed patch

Review of attachment 656312 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review
Attachment #656312 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/67c5a4852b9f
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.