Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 785805 - Segmentation fault when calling %ThrowError for message with three arguments
: Segmentation fault when calling %ThrowError for message with three arguments
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: All All
: -- normal (vote)
: mozilla18
Assigned To: Norbert Lindenberg
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 784288 769872
  Show dependency treegraph
Reported: 2012-08-26 23:47 PDT by Norbert Lindenberg
Modified: 2012-08-29 17:21 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

proposed patch (1.05 KB, patch)
2012-08-27 00:29 PDT, Norbert Lindenberg
jorendorff: review+
Details | Diff | Splinter Review
test case (not to be checked in) (1.61 KB, text/plain)
2012-08-28 19:50 PDT, Norbert Lindenberg
no flags Details
proposed patch (1.13 KB, patch)
2012-08-28 20:03 PDT, Norbert Lindenberg
till: review+
Details | Diff | Splinter Review

Description Norbert Lindenberg 2012-08-26 23:47:38 PDT
Using the %ThrowError intrinsic from self-hosted code causes a segmentation fault if formatting a message with three arguments.
Comment 1 Norbert Lindenberg 2012-08-27 00:29:19 PDT
Created attachment 655534 [details] [diff] [review]
proposed patch
Comment 2 Norbert Lindenberg 2012-08-28 19:50:55 PDT
Created attachment 656309 [details]
test case (not to be checked in)

After building with this patch, use the shell to run


This should throw an exception with the strings "arg 1", "arg 2", "arg 3" embedded in the message. It should not cause a segmentation fault.
Comment 3 Norbert Lindenberg 2012-08-28 20:03:21 PDT
Created attachment 656312 [details] [diff] [review]
proposed patch

Rebased to current mozilla-central, which did change the changed line (from int to unsigned), and improved the commit message.
Comment 4 Till Schneidereit [:till] 2012-08-29 04:27:12 PDT
Comment on attachment 656312 [details] [diff] [review]
proposed patch

Review of attachment 656312 [details] [diff] [review]:

Stealing review
Comment 5 Till Schneidereit [:till] 2012-08-29 04:34:18 PDT
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-08-29 17:21:06 PDT

Note You need to log in before you can comment on or make changes to this bug.