Last Comment Bug 785807 - wrong icon of Previous Msg button in disabled state, after bug 650170
: wrong icon of Previous Msg button in disabled state, after bug 650170
Status: VERIFIED FIXED
: regression
Product: Thunderbird
Classification: Client Software
Component: Toolbars and Tabs (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 17.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks: TB-AppMenu
  Show dependency treegraph
 
Reported: 2012-08-26 23:59 PDT by :aceman
Modified: 2012-08-27 13:38 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
screenshot of disabled button - wrong icon (5.98 KB, image/png)
2012-08-27 00:00 PDT, :aceman
no flags Details
screenshot of enabled button - good icon (5.92 KB, image/png)
2012-08-27 00:00 PDT, :aceman
no flags Details
patch (3.07 KB, patch)
2012-08-27 09:25 PDT, Richard Marti (:Paenglab)
bwinton: review+
acelists: feedback+
Details | Diff | Splinter Review

Description User image :aceman 2012-08-26 23:59:24 PDT
Patch in bug 650170 (I assume) broke the display of the "Previous Msg" button icon. When in the disabled state, it shows the new Thundebird button icon (new menu), instead of the proper icon (blue up arrow). Can be seen on Linux and Windows XP.
Comment 1 User image :aceman 2012-08-27 00:00:13 PDT
Created attachment 655532 [details]
screenshot of disabled button - wrong icon
Comment 2 User image :aceman 2012-08-27 00:00:46 PDT
Created attachment 655533 [details]
screenshot of enabled button - good icon
Comment 3 User image Richard Marti (:Paenglab) 2012-08-27 00:32:52 PDT
Found problem - silly copy/paste error. Patch comes this evening.
Comment 4 User image Richard Marti (:Paenglab) 2012-08-27 09:25:29 PDT
Created attachment 655613 [details] [diff] [review]
patch

Fixing the copy/paste error (not changed after paste)
Comment 5 User image :aceman 2012-08-27 11:45:05 PDT
Comment on attachment 655613 [details] [diff] [review]
patch

This patch fixes the problem for me. Tested on Linux only. Thanks
Comment 6 User image Blake Winton (:bwinton) (:☕️) 2012-08-27 12:02:32 PDT
Comment on attachment 655613 [details] [diff] [review]
patch

Seems good.  r=me.
Comment 7 User image Mike Conley (:mconley) 2012-08-27 12:08:03 PDT
comm-central: https://hg.mozilla.org/comm-central/rev/47b7d3a0c50c

Note You need to log in before you can comment on or make changes to this bug.