Closed
Bug 785832
Opened 13 years ago
Closed 13 years ago
[ACR] Oversized icon
Categories
(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kinger, Assigned: kinger)
References
Details
The icon for the Tumblr icon is oversized.
See:
https://dl.dropbox.com/u/5940796/acr/BigIcon.png
Add-on:
https://addons.mozilla.org/en-US/firefox/addon/tumblr-1/
|
Assignee | |
Updated•13 years ago
|
Assignee: dave → briks.si
Status: NEW → ASSIGNED
OS: Mac OS X → All
|
|
Assignee | |
Comment 1•13 years ago
|
||
The issue here is that addon.iconURL for addons returned from AddonManager.getAllAddons uses the file icon.png bundled inside the add-on. There is a recommended size for this, but some add-ons ship different sizes. Tumblr is shipping 128x128.
My solution was to constrain/scale the image using CSS. In the Submit views, it is 64x64, and in the list view it is 48x48. Only larger icons are scaled down, smaller ones are not scaled up.
https://github.com/brianking/ACR/commit/1f28307876ef73de763c0b5253c1660f8fd0f218
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•