Closed Bug 785964 Opened 7 years ago Closed 7 years ago

NEWTAB_PAGE_PINNED_SITES_COUNT should be an enumerated histogram, not an exponential one

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
I don't *think* the actual distribution of buckets is any different between the exponential histogram we had and the enumerated histogram we will have post-patch, but I renamed the histogram just to be sure.
Attachment #655667 - Flags: review?(ttaubert)
Comment on attachment 655667 [details] [diff] [review]
patch

Didn't see that ttaubert was on vacation.

Bouncing to taras; I really don't think a renaming in browser/ should require a browser review peer...
Attachment #655667 - Flags: review?(ttaubert) → review?(taras.mozilla)
Comment on attachment 655667 [details] [diff] [review]
patch

We only need to change the histogram name if it changes what data is sent to the server. This would not change that. Should be ok to just change the .json
Attachment #655667 - Flags: review?(taras.mozilla) → review-
Attached patch patchSplinter Review
Now with just changing the histogram parameters.
Attachment #655667 - Attachment is obsolete: true
Attachment #655749 - Flags: review?(taras.mozilla)
Comment on attachment 655749 [details] [diff] [review]
patch

thanks
Attachment #655749 - Flags: review?(taras.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e36689713d6c

Doh, landed with the wrong r=.  Maybe Tim can get extra credit for working on his time off. ;)
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e36689713d6c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.