785964 - NEWTAB_PAGE_PINNED_SITES_COUNT should be an enumerated histogram, not an exponential one

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

I don't *think* the actual distribution of buckets is any different between the exponential histogram we had and the enumerated histogram we will have post-patch, but I renamed the histogram just to be sure.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 655667 [details] [diff] [review]
patch

Didn't see that ttaubert was on vacation.

Bouncing to taras; I really don't think a renaming in browser/ should require a browser review peer...

Comment 3

[(dormant account)]

Comment on attachment 655667 [details] [diff] [review]
patch

We only need to change the histogram name if it changes what data is sent to the server. This would not change that. Should be ok to just change the .json

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: patch

Now with just changing the histogram parameters.

Comment 5

[(dormant account)]

Comment on attachment 655749 [details] [diff] [review]
patch

thanks

Comment 6

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e36689713d6c

Doh, landed with the wrong r=.  Maybe Tim can get extra credit for working on his time off. ;)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e36689713d6c