Closed
Bug 786010
Opened 12 years ago
Closed 12 years ago
create manifest as part of the clang build
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file)
|
3.25 KB,
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•12 years ago
|
Attachment #655713 -
Flags: review?(rail)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → respindola
Status: NEW → ASSIGNED
|
||
Comment 1•12 years ago
|
||
Comment on attachment 655713 [details] [diff] [review]
create manifest as part of the clang build
Review of attachment 655713 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/unix/build-clang/build-clang.py
@@ +103,5 @@
> + setup = basedir + '/setup.sh'
> + manifest = 'clang.manifest'
> + check_run(['python', tooltool, '-m', 'clang.manifest', 'add',
> + setup, 'clang.tar.bz2'])
> + data = eval(file('clang.manifest').read())
Could you use simplejson.reads() instead of eval here?
Attachment #655713 -
Flags: review?(rail) → review+
|
||
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•