create manifest as part of the clang build

RESOLVED FIXED

Status

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee: nobody → respindola
Status: NEW → ASSIGNED
Comment on attachment 655713 [details] [diff] [review]
create manifest as part of the clang build

Review of attachment 655713 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/build-clang/build-clang.py
@@ +103,5 @@
> +    setup = basedir + '/setup.sh'
> +    manifest = 'clang.manifest'
> +    check_run(['python', tooltool, '-m', 'clang.manifest', 'add',
> +               setup, 'clang.tar.bz2'])
> +    data = eval(file('clang.manifest').read())

Could you use simplejson.reads() instead of eval here?
Attachment #655713 - Flags: review?(rail) → review+
https://hg.mozilla.org/mozilla-central/rev/dbeed4d1e204
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.