Closed
Bug 786031
Opened 12 years ago
Closed 12 years ago
nsFrame.cpp:846:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.08 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
nsFrame.cpp spams 6 lines of GCC warnings right now:
{
../../../mozilla/layout/generic/nsFrame.cpp: In member function ‘virtual nsMargin nsIFrame::GetUsedMargin() const’:
../../../mozilla/layout/generic/nsFrame.cpp:846:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
../../../mozilla/layout/generic/nsFrame.cpp: In member function ‘virtual nsMargin nsIFrame::GetUsedBorder() const’:
../../../mozilla/layout/generic/nsFrame.cpp:869:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
../../../mozilla/layout/generic/nsFrame.cpp: In member function ‘virtual nsMargin nsIFrame::GetUsedPadding() const’:
../../../mozilla/layout/generic/nsFrame.cpp:905:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
}
These are for the "||" clauses added in this diff:
https://hg.mozilla.org/mozilla-central/diff/f4f26647c555/layout/generic/nsFrame.cpp
for bug 655877.
Attachment #655739 -
Flags: review?(cam)
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•12 years ago
|
Attachment #655739 -
Attachment description: fix v1 → fix v1: add implied parens around "&&"
|
||
Comment 1•12 years ago
|
||
Comment on attachment 655739 [details] [diff] [review] fix v1: add implied parens around "&&" Thanks Daniel.
Attachment #655739 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/16f3f0aab884
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/16f3f0aab884
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•