Closed Bug 786032 Opened 8 years ago Closed 8 years ago

Make search timeouts work correctly when they timeout

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: jgriffin, Assigned: jgriffin)

Details

Attachments

(1 file)

When searching for an element that isn't found with a specified search timeout, Marionette currently hangs.  This is because the current implementation throws an exception within an asynchronous callback, which gets silently eaten.

The current implementation works OK if there is a search timeout of 0, since then the exception gets propagated back to the caller, where it is handled appropriately.
Attachment #655748 - Flags: review?(mdas)
Comment on attachment 655748 [details] [diff] [review]
Make search timeouts fail successfully,  DONTBUILD because NPOTB

Review of attachment 655748 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!
Attachment #655748 - Flags: review?(mdas) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a41f262b382
Assignee: nobody → jgriffin
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/8a41f262b382
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.