786051 - Pages with big favicons don't create pretty shortcuts

Status: RESOLVED DUPLICATE of bug 783921

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

I added some nice high res favicons to the minimart. They look a little.... messed up when drawn as launcher icons because they're bigger than what my phone wants. We should either

a.) Just draw these the same as we do for webapps (i.e. scale the icon to the right size and don't add a background

or b.) Draw them to fit inside the box

I'm going to take b here so that there's a difference between webapps and favicons, BUT... I'm not sure that is good enough of a reason. Opinion?

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Screenshot of both options

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 655768 [details] [diff] [review]
Patch

Help me understand this first. When you say "favicon" and  "shortcut", does that mean you are just adding a shortcut to the homescreen? or are you installing a webapp?

Comment 4

[Wesley Johnston (:wesj)]

Heh. We need to refine our language here, but I'm talking about adding a shortcut to the homescreen. i.e. cases where we're drawing our special rectangle behind the icon.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

OK. Shortcuts, not WebApps, should always use the "background", so using approach B should be the right way.

Comment 6

[Wesley Johnston (:wesj)]

I moved this patch to bug 783921.

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 655768 [details] [diff] [review]
Patch

I fixed this in bug 783921