Closed
Bug 786075
Opened 12 years ago
Closed 12 years ago
Fix commonware deprecation warning about HidePasswordOnException
Categories
(Webtools Graveyard :: Elmo, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.3
People
(Reporter: peterbe, Assigned: peterbe)
Details
Attachments
(1 file)
|
418 bytes,
patch
|
rrosario
:
review+
|
Details | Diff | Splinter Review |
I get this every time:: /Users/peterbe/dev/MOZILLA/ELMO/elmo/vendor/src/commonware/commonware/exceptions/middleware.py:33: DeprecationWarning: The middleware at `commonware.middleware.HidePasswordOnException` is deprecated; use `commonware.middleware.ScrubRequestOnException` instead. DeprecationWarning
|
Assignee | |
Comment 1•12 years ago
|
||
/me spending more time creating bugs, branches, patches, attachments, comments than I do things :)
Attachment #655793 -
Flags: review?(l10n)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #655793 -
Flags: review?(l10n) → review?(rrosario)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 655793 [details] [diff] [review] voila Review of attachment 655793 [details] [diff] [review]: ----------------------------------------------------------------- perfecto!
Attachment #655793 -
Flags: review?(rrosario) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/0b55eabf6acd6b44f1cc99a8fd18136471b76716 bug 785075 - switch from HidePasswordOnException to ScrubRequestOnException, r=r1cky
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Assignee: nobody → peterbe
Target Milestone: --- → 2.3
|
||
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•