Fix commonware deprecation warning about HidePasswordOnException

RESOLVED FIXED in 2.3

Status

Webtools
Elmo
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I get this every time::

 /Users/peterbe/dev/MOZILLA/ELMO/elmo/vendor/src/commonware/commonware/exceptions/middleware.py:33: DeprecationWarning: The middleware at `commonware.middleware.HidePasswordOnException` is deprecated; use `commonware.middleware.ScrubRequestOnException` instead.
  DeprecationWarning
(Assignee)

Comment 1

6 years ago
Created attachment 655793 [details] [diff] [review]
voila

/me spending more time creating bugs, branches, patches, attachments, comments than I do things :)
Attachment #655793 - Flags: review?(l10n)
(Assignee)

Updated

6 years ago
Attachment #655793 - Flags: review?(l10n) → review?(rrosario)
Comment on attachment 655793 [details] [diff] [review]
voila

Review of attachment 655793 [details] [diff] [review]:
-----------------------------------------------------------------

perfecto!
Attachment #655793 - Flags: review?(rrosario) → review+
(Assignee)

Comment 3

6 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/0b55eabf6acd6b44f1cc99a8fd18136471b76716
bug 785075 - switch from HidePasswordOnException to ScrubRequestOnException, r=r1cky
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Assignee: nobody → peterbe
Target Milestone: --- → 2.3
You need to log in before you can comment on or make changes to this bug.