The default bug view has changed. See this FAQ.

Lack for pdfjs/content/web/images/toolbarButton-fullscreen.png

RESOLVED FIXED in Firefox 17

Status

()

Firefox
PDF Viewer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tetsuharu, Assigned: tetsuharu)

Tracking

Trunk
Firefox 18
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

At Bug 784718, we update pdf.js to 0.4.11.
But its commit lack for pdfjs/content/web/images/toolbarButton-fullscreen.png.
Created attachment 655960 [details] [diff] [review]
patch

This patch is for mozilla-central 18.
And also the patch is needed to approval-aurora 17.
Attachment #655960 - Flags: review?(dtownsend+bugmail)
(Assignee)

Updated

5 years ago
Blocks: 784718
Comment on attachment 655960 [details] [diff] [review]
patch

r=whatever
Attachment #655960 - Flags: review?(dtownsend+bugmail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
What practical effects does this image being missing have?
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> What practical effects does this image being missing have?

Not showing the full-screen icon in PDF viewer.
It should be shown next to the "Download" icon.
https://hg.mozilla.org/integration/mozilla-inbound/rev/acb866bc42c2
Flags: in-testsuite-
Keywords: checkin-needed
Assignee: nobody → saneyuki.s.snyk
Comment on attachment 655960 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 784718
User impact if declined: Not showing the full-screen icon in PDF viewer next to the download icon.
Testing completed (on m-c, etc.): Local testing. On inbound.
Risk to taking this patch (and alternatives if risky): Very little.
String or UUID changes made by this patch: None.
Attachment #655960 - Flags: approval-mozilla-aurora?

Comment 7

5 years ago
PDF.js was disabled by default in bug 786012 for FF16/17. What's the motivation for fixing this on Aurora given that?
Comment on attachment 655960 [details] [diff] [review]
patch

Some people might want to enable it for testing, or something. Doesn't really hurt to take it for consistency, IMO, since there's no risk.
Attachment #655960 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/cb69436c3056
status-firefox17: --- → fixed
status-firefox18: --- → fixed
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #8)
> Some people might want to enable it for testing, or something. Doesn't
> really hurt to take it for consistency, IMO, since there's no risk.

We normally don't take fixes for features that are disabled by default, and enabled through about:config. Tinkerers can always get their fix on Nightly. It's mostly a matter of consistency in triage and landings.

Understood that a file addition is obviously low risk though.
https://hg.mozilla.org/mozilla-central/rev/acb866bc42c2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.