786324 - Don't show the browserID login/register link on the Additional Authorization popup

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/developers/
2. Log in with an admin account
3. Notice the additional authorization popup

expected behavior:
We don't link to browserID login which may cause confusion to users trying to log in.

observed behavior:
Only on /developers, we show browserID login/register link on the Additional Authorization popup. See screenshot.

Comment 1

[Fred Wenzel [:wenzel]]

What's the right thing to do here? Do we just need to change the link? I thought the login behavior was defined outside the devhub.

Comment 2

[Fred Wenzel [:wenzel]]

Jen should just remove those links at the top of the devhub's front page altogether. "Reference" is a legacy link to MDN, that needs to go, and "login" is pointless unless it is for the purpose of submitting an app. Submitting, however, already has a big button.

So let's remove those links all the way and we can iterate from there down the road (and re-add login if there is a reason for people to be logged into the devhub).

CCing clouserw for sanity check.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Fixed:
https://github.com/mozilla/zamboni/commit/38b7e3e

(In reply to Fred Wenzel [:wenzel] from comment #2)
> Jen should just remove those links at the top of the devhub's front page
> altogether. "Reference" is a legacy link to MDN, that needs to go, and
> "login" is pointless unless it is for the purpose of submitting an app.
> Submitting, however, already has a big button.
> 
> So let's remove those links all the way and we can iterate from there down
> the road (and re-add login if there is a reason for people to be logged into
> the devhub).

Yeah, that's fine but outside the scope of this bug.

When we made the DevHub/ecosystem styles not dependent on consumer pages, we forgot the login styles. NBD.

Comment 4

[krupa raj[:krupa]]

verified at https://marketplace-dev.allizom.org/developers/

Comment 5

[krupa raj[:krupa]]

Attachment: post-fix screenshot