786358 - Port bug 773641 to Thunderbird's WebSearch.

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Blake Winton (:bwinton) (:☕️)]

Or just use the icon that's landing in central, if we can do that.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Using the Twitter icon we have already for chat.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 656173 [details] [diff] [review]
patch

I'm going to be annoyed if mozilla-central ends up with a different icon, but for now, r=me.  ;)

(Also, what do you think about base64-ing the other search icons?)

Comment 3

[Blake Winton (:bwinton) (:☕️)]

As a note, please don't land this until we have the final permission to use these icons in the dependent bug…

Thanks,
Blake.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #2)
> Comment on attachment 656173 [details] [diff] [review]
> patch
> 
> I'm going to be annoyed if mozilla-central ends up with a different icon,
> but for now, r=me.  ;)

M-c has now also a patch and is using the same icon. The only difference is, I optimized the PNG image to be smaller.

> (Also, what do you think about base64-ing the other search icons?)

All other icons except the AOL icon are also base64 encoded. I don't know how to convert this to base64 (I can't create a png of it). But I also see, http://search.aol.com/aol/search uses now a other icon. Should I use this?

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Nah, let's leave it the way it is.

Comment 6

[Richard Marti (:Paenglab)]

The related bug landed. Is it okay land this too?

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Yep.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/d66004eb6054

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 656173 [details] [diff] [review]
patch

[Approval Request Comment]
As it's not clear if and when TB 18 and ff. will be released as a normal version, it would be good if this new icon can land on TB 17 and TB 17 ESR.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 656173 [details] [diff] [review]
patch

I think you mean to ask for comm-aurora approval here, changing the flags.

Comment 11

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/releases/comm-aurora/rev/ff17ebcb7403