Closed Bug 786358 Opened 9 years ago Closed 9 years ago

Port bug 773641 to Thunderbird's WebSearch.

Categories

(Thunderbird :: Search, defect)

x86
macOS
defect
Not set
normal

Tracking

(thunderbird17 fixed)

RESOLVED FIXED
Thunderbird 18.0
Tracking Status
thunderbird17 --- fixed

People

(Reporter: bwinton, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Or just use the icon that's landing in central, if we can do that.
Attached patch patchSplinter Review
Using the Twitter icon we have already for chat.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #656173 - Flags: review?(bwinton)
Comment on attachment 656173 [details] [diff] [review]
patch

I'm going to be annoyed if mozilla-central ends up with a different icon, but for now, r=me.  ;)

(Also, what do you think about base64-ing the other search icons?)
Attachment #656173 - Flags: review?(bwinton) → review+
As a note, please don't land this until we have the final permission to use these icons in the dependent bug…

Thanks,
Blake.
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #2)
> Comment on attachment 656173 [details] [diff] [review]
> patch
> 
> I'm going to be annoyed if mozilla-central ends up with a different icon,
> but for now, r=me.  ;)

M-c has now also a patch and is using the same icon. The only difference is, I optimized the PNG image to be smaller.

> (Also, what do you think about base64-ing the other search icons?)

All other icons except the AOL icon are also base64 encoded. I don't know how to convert this to base64 (I can't create a png of it). But I also see, http://search.aol.com/aol/search uses now a other icon. Should I use this?
Nah, let's leave it the way it is.
The related bug landed. Is it okay land this too?
Yep.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/d66004eb6054
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment on attachment 656173 [details] [diff] [review]
patch

[Approval Request Comment]
As it's not clear if and when TB 18 and ff. will be released as a normal version, it would be good if this new icon can land on TB 17 and TB 17 ESR.
Attachment #656173 - Flags: approval-mozilla-aurora?
Comment on attachment 656173 [details] [diff] [review]
patch

I think you mean to ask for comm-aurora approval here, changing the flags.
Attachment #656173 - Flags: approval-mozilla-aurora? → approval-comm-aurora?
Attachment #656173 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.