78641 - [console] xmlterm must not print to console in opt builds

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[cls]

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>

Comment 1

[cls]

Attachment: prelim patch

Comment 2

[cls]

Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 3

[R. Saravanan]

I'll try to clean up the xmlterm code some more, but for the moment the patch
looks OK to me (r=svn)

Comment 4

[chris hofmann]

lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.

Comment 5

[gabriel]

Is there any point to this ? Xmlterm hasn't been updated since November 2000,
and doesn't work with the latest mozilla builds anyway.

It's a pity, it seemed like a very nice app.

Comment 6

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 7

[Hixie (not reading bugmail)]

moving out to 0.9.4 to get this out of the 0.9.3 radar.

Comment 8

[gabriel]

I suggest removing the milestone since xmlterm seems to be dead.

Comment 9

[R. Saravanan]

Milestoned to 0.9.5 (I am in the process of restructuring the xmlterm code)

Comment 10

[gabriel]

Yay :-)

Comment 11

[R. Saravanan]

Fix checked in. Many printf's have been removed. Those that remain are ifdef'ed
out of non-debug builds.