786411 - [dev] Navigating to branch data sources in the admin UI returns a 500 error

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Matt Brandt [:mbrandt]]

Navigating to branch data sources in the admin UI returns a 500 error.

Steps to reproduce:
1. goto https://crash-stats-dev.allizom.org/admin/branch_data_sources

Actual:
[12:17:49.503] GET https://crash-stats-dev.allizom.org/admin/branch_data_sources [HTTP/1.1 500 Internal Server Error 154ms]

Comment 1

[Robert Helmer [:rhelmer]]

curl 'http://socorro-api-dev-internal/bpapi/products/versions/1'
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] Traceback (most recent call last):
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]   File "/data/socorro/thirdparty/web/application.py", line 237, in process
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     return self.handle()
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]   File "/data/socorro/thirdparty/web/application.py", line 228, in handle
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     return self._delegate(fn, self.fvars, args)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]   File "/data/socorro/thirdparty/web/application.py", line 394, in _delegate
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     return handle_class(f)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]   File "/data/socorro/thirdparty/web/application.py", line 385, in handle_class
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     return tocall(*args)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]   File "/data/socorro/application/socorro/webapi/webapiService.py", line 79, in GET
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     raise Exception(stringLogger.getMessages())
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] Exception: ERROR Caught Error: <class 'psycopg2.ProgrammingError'>
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR syntax error at end of input
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] LINE 11:          
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]                   ^
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] 
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR trace back follows:
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR Traceback (most recent call last):
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR File "/data/socorro/application/socorro/webapi/webapiService.py", line 64, in GET
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     result = self.get(*args)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR File "/data/socorro/application/socorro/middleware/products_service.py", line 28, in get
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     return impl.get(**params)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR File "/data/socorro/application/socorro/external/postgresql/products.py", line 30, in get
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     return self._get_versions(params)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR File "/data/socorro/application/socorro/external/postgresql/products.py", line 85, in _get_versions
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     for product in results:
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR File "/data/socorro/application/socorro/database/database.py", line 91, in execute
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]     aCursor.execute(sql, parameters)
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] ERROR ProgrammingError: syntax error at end of input
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64] LINE 11:          
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]                   ^
[Tue Aug 28 12:37:43 2012] [error] [client 10.8.74.64]

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

I believe the problem happens when the /products service is called with an empty list of versions. Looking at the code it seems to be coherent. I'll work on a fix tomorrow.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/806

Steps to QA
-----------

1. Go to the branch admin page
2. Verify that it works as expected, see bug 772924

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c88e7277755df82757333fcf4134afb991ca4094
Fixes bug 786411 - The products service now returns full versions list when no valid versions passed

https://github.com/mozilla/socorro/commit/b735d0b8ba651b0b5dab412d7445612bfbd31295
Merge pull request #806 from AdrianGaudebert/786411-products-service-empty-versions-list

Fixes bug 786411 - The products service now returns full versions list w...

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

[19:03:34.301] GET https://crash-stats.allizom.org/admin/branch_data_sources [HTTP/1.1 200 OK 526ms]

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 659084 [details]
Post-fix screenshot

Wrong image!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot