Closed Bug 786425 Opened 12 years ago Closed 12 years ago

Java agent should always log to logcat, even if it's not logging to a file

Categories

(Testing Graveyard :: SUTAgent, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(1 file)

When we changed the behaviour to not log to a file by default, we also took out the logging to logcat behaviour as well. This was useful and should not cause problems, so we should re-enable it.
I also changed the method to log, to make it clearer that it won't always log to a file.
Attachment #656181 - Flags: review?(jmaher)
Comment on attachment 656181 [details] [diff] [review]
Reenable logging to logcat by default

Review of attachment 656181 [details] [diff] [review]:
-----------------------------------------------------------------

the DoCommand.java changes look like they are snuck in for raw logging.  A good cleanup though.
Attachment #656181 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #2)
> Comment on attachment 656181 [details] [diff] [review]
> Reenable logging to logcat by default
> 
> Review of attachment 656181 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> the DoCommand.java changes look like they are snuck in for raw logging.  A
> good cleanup though.

Good catch, I fixed this before pushing
https://hg.mozilla.org/mozilla-central/rev/9d3b36dbeada
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: