78644 - [console] beos port should not print to console for opt builds

Status: RESOLVED WORKSFORME

(Core Graveyard :: GFX: BeOS, defect, P2)

Description

[cls]

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>

Comment 1

[cls]

Attachment: prelim patch

Comment 2

[cls]

Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 3

[chris hofmann]

lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.

Comment 4

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone.  Please correct if I'm mistaken.

Comment 5

[chris hofmann]

doesn't look like it made 0.9.4 either. 
let's figure out the right milestone and assign.. 
thanks

Comment 6

[kurros (Wade Majors)]

Reassigning to component owner/qa contact. I am not working on BeOS anymore.

Comment 7

[Paul]

i'll look into this, at least the beos specific parts 

Comment 8

[Paul]

I'll take this.  I'm not saying I'll be looking into it any time soon, but, at
least it will now show up on my list of things to do :-)

Comment 9

[timeless]

Comment on attachment 33014 [details] [diff] [review]
prelim patch

1. i'm not sure i've ever really seen these messages.
2. if we actually did hit these codepaths, i think i'd want someone to consider
them and complain. (i suppose that means i should change them to NS_ASSERTION
or NS_WARNING. perhaps the right thing to do is to switch them to NS_WARNING,
that would give the intended result of no console output in debug...)
3. i don't see much point in it. it's not like netscape is making a beos
release anytime soon.

Comment 10

[Paul]

Well, under normal operation on a release build, I have not seen any output to
the console even once.
I am going to close this, to get it off my list.
If anyone has any objections, re-open it.