[console] beos port should not print to console for opt builds

RESOLVED WORKSFORME

Status

Core Graveyard
GFX: BeOS
P2
trivial
RESOLVED WORKSFORME
17 years ago
9 years ago

People

(Reporter: cls, Assigned: Paul)

Tracking

Trunk
Future
x86
BeOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>
(Reporter)

Comment 1

17 years ago
Created attachment 33014 [details] [diff] [review]
prelim patch
(Reporter)

Updated

17 years ago
Blocks: 76720
Keywords: mozilla0.9.1
Priority: -- → P2
(Reporter)

Comment 2

17 years ago
Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Updated

17 years ago
Target Milestone: --- → mozilla1.0

Comment 3

17 years ago
lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.
Target Milestone: mozilla1.0 → mozilla0.9.2

Updated

17 years ago
Target Milestone: mozilla0.9.2 → mozilla0.9.3

Comment 4

17 years ago
Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone.  Please correct if I'm mistaken.

Updated

17 years ago
Target Milestone: mozilla0.9.3 → mozilla0.9.4

Comment 5

17 years ago
doesn't look like it made 0.9.4 either. 
let's figure out the right milestone and assign.. 
thanks
Target Milestone: mozilla0.9.4 → ---

Comment 6

16 years ago
Reassigning to component owner/qa contact. I am not working on BeOS anymore.
Assignee: wade → seawood
OS: All → BeOS
Hardware: All → PC
Target Milestone: --- → Future
(Assignee)

Comment 7

16 years ago
i'll look into this, at least the beos specific parts 
Status: NEW → ASSIGNED
(Assignee)

Comment 8

15 years ago
I'll take this.  I'm not saying I'll be looking into it any time soon, but, at
least it will now show up on my list of things to do :-)
Assignee: seawood → arougthopher
Status: ASSIGNED → NEW

Comment 9

15 years ago
Comment on attachment 33014 [details] [diff] [review]
prelim patch

1. i'm not sure i've ever really seen these messages.
2. if we actually did hit these codepaths, i think i'd want someone to consider
them and complain. (i suppose that means i should change them to NS_ASSERTION
or NS_WARNING. perhaps the right thing to do is to switch them to NS_WARNING,
that would give the intended result of no console output in debug...)
3. i don't see much point in it. it's not like netscape is making a beos
release anytime soon.

Updated

15 years ago
Component: Build Config → GFX: BeOS
QA Contact: granrose → timeless
(Assignee)

Comment 10

15 years ago
Well, under normal operation on a release build, I have not seen any output to
the console even once.
I am going to close this, to get it off my list.
If anyone has any objections, re-open it.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.