Status

VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: mkelly, Assigned: mkelly)

Tracking

unspecified

Details

(URL)

(Assignee)

Description

6 years ago
Traceback (most recent call last):

  File "/data/www/affiliates-fb-dev.allizom.org/affiliates-app/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/affiliates-fb-dev.allizom.org/affiliates-app/vendor/src/django/django/views/decorators/http.py", line 45, in inner
    return func(request, *args, **kwargs)

  File "/data/www/affiliates-fb-dev.allizom.org/affiliates-app/vendor/src/django/django/views/decorators/csrf.py", line 39, in wrapped_view
    resp = view_func(*args, **kwargs)

  File "/data/www/affiliates-fb-dev.allizom.org/affiliates-app/vendor/src/django/django/views/decorators/csrf.py", line 52, in wrapped_view
    return view_func(*args, **kwargs)

  File "/data/www/affiliates-fb-dev.allizom.org/affiliates-app/vendor/src/commonware/commonware/response/decorators.py", line 18, in _wrapped_view
    response = view_fn(request, *args, **kwargs)

  File "/data/www/affiliates-fb-dev.allizom.org/affiliates-app/apps/facebook/views.py", line 57, in load_app
    user.country = decoded_request['user']['country']

KeyError: 'country'
(Assignee)

Comment 1

6 years ago
Fixed in https://github.com/mozilla/affiliates/commit/6ceab7d822545e8a4a3ece1086c0c04e8bb87954

Will monitor traceback emails and verify this myself since rbillings isn't on the traceback list.
Assignee: nobody → mkelly
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

6 years ago
The tracebacks have stopped since this fix went out. Looks verified to me. :D
Status: RESOLVED → VERIFIED

Comment 3

6 years ago
Commit pushed to develop at https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/6b57d2c189f1ea22e4d7e55531db9535a96d9e72
Fix tracebacks when user country is not supplied.

fix bug 786441

Updated

6 years ago
Status: VERIFIED → RESOLVED
Last Resolved: 6 years ago6 years ago
(Assignee)

Comment 4

6 years ago
Bugcloser is dumb
Status: RESOLVED → VERIFIED
Product: Firefox Affiliates → Firefox Affiliates Graveyard
You need to log in before you can comment on or make changes to this bug.