Closed Bug 78646 Opened 23 years ago Closed 19 years ago

[console] htmlparser must not print to console in opt builds

Categories

(Core :: DOM: HTML Parser, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: cls, Assigned: harishd)

References

Details

Attachments

(1 file)

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>
Blocks: 76720
Keywords: mozilla0.9.1
Priority: -- → P2
Attached patch prelim patchSplinter Review
Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
76720 is targetted for 0.9.1. can this be moved up?
ya sure. Shouldn't be too much work.
Target Milestone: mozilla0.9.2 → mozilla0.9.1
lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Priority: P2 → P3
moving to 0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Moving to more realistic target - m0.9.4!
Target Milestone: mozilla0.9.3 → mozilla0.9.4
--> 0.9.5
Target Milestone: mozilla0.9.4 → mozilla0.9.5
QA Contact: bsharma → moied
--> 0.9.6
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Moving lower priority bugs to m1.0.
Target Milestone: mozilla0.9.6 → mozilla1.0
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug, or if it blocks your work in some way
 -- please attach your concern to the bug for reconsideration. 
Target Milestone: mozilla1.0.1 → Future
Choess, care to take a shot at this?  Most of those method declarations and
implementations should just be inside #ifdef DEBUG....
These are all gone.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: