Closed Bug 786463 Opened 7 years ago Closed 7 years ago

Marionette should mark TEST-START and TEST-END in the log

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: jgriffin, Assigned: jgriffin)

Details

Attachments

(1 file)

Currently, Marionette outputs log messages to gecko's stdout, but we don't output the start or end of test.  Thus, it's hard to tell which log statements belong to tests. 

We should be output something similar to mochitest:

INFO TEST-START: test_something.py:test_something_good
 ...
INFO TEST-END: test_something.py:test_something_good

We can achieve this by having MarionetteTestCase call Marionette's log() method with the test name at the start and end of a test.
Turns out this wouldn't have been a very good first-bug, due to the bug in executeJSScript that was eating newSandbox, which this patch fixes (since without it, the logging messes up the subsequent script).
Attachment #656280 - Flags: review?(mdas)
Comment on attachment 656280 [details] [diff] [review]
Add TEST-START and TEST-END logging,  DONTBUILD because NPOTB

Review of attachment 656280 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: testing/marionette/marionette-actors.js
@@ +631,5 @@
>      else {
> +      this.sendAsync("executeJSScript", { value:aRequest.value,
> +                                          args:aRequest.args,
> +                                          newSandbox:aRequest.newSandbox,
> +                                          timeout:aRequest.timeout });

ah, good catch :)
Attachment #656280 - Flags: review?(mdas) → review+
https://hg.mozilla.org/mozilla-central/rev/616ff690fdc3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.