Closed
Bug 786463
Opened 12 years ago
Closed 12 years ago
Marionette should mark TEST-START and TEST-END in the log
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: jgriffin, Assigned: jgriffin)
Details
Attachments
(1 file)
3.62 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
Currently, Marionette outputs log messages to gecko's stdout, but we don't output the start or end of test. Thus, it's hard to tell which log statements belong to tests. We should be output something similar to mochitest: INFO TEST-START: test_something.py:test_something_good ... INFO TEST-END: test_something.py:test_something_good We can achieve this by having MarionetteTestCase call Marionette's log() method with the test name at the start and end of a test.
Assignee | ||
Comment 1•12 years ago
|
||
Turns out this wouldn't have been a very good first-bug, due to the bug in executeJSScript that was eating newSandbox, which this patch fixes (since without it, the logging messes up the subsequent script).
Attachment #656280 -
Flags: review?(mdas)
Comment 2•12 years ago
|
||
Comment on attachment 656280 [details] [diff] [review] Add TEST-START and TEST-END logging, DONTBUILD because NPOTB Review of attachment 656280 [details] [diff] [review]: ----------------------------------------------------------------- lgtm ::: testing/marionette/marionette-actors.js @@ +631,5 @@ > else { > + this.sendAsync("executeJSScript", { value:aRequest.value, > + args:aRequest.args, > + newSandbox:aRequest.newSandbox, > + timeout:aRequest.timeout }); ah, good catch :)
Attachment #656280 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/616ff690fdc3
Target Milestone: --- → mozilla18
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/616ff690fdc3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•