786518 - Non-public events hard-wired for PR approval.

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Richard A Milewski[:richard]]

Events created without checking the "Public" box have "PR" in the Approvals list.
PR approval is only required for publicly streamed events.

Comment 1

[Peter Bengtsson [:peterbe]]

Events that are NOT Public are private and surely don't need any approvals. 

Also, I tried to create a Public event and chose not to click any Approvals and that worked too. If you don't select PR in the Approvals box, PR won't need to approve the event.

Comment 2

[Richard A Milewski[:richard]]

OK... this is a user training issue.  What we have now is a box with PR in it.  I was reading this as PR being selected because it's visible.  This is the only box on that form where "selected" is indicated by blue highlighting.  We need to either change this to an array of checkboxes, one for each approval group, or add a hint near the box that explains how this works.

Comment 3

[Peter Bengtsson [:peterbe]]

I agree. Checkboxes do a much better job "describing" the state.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/0e7260eae10faa885b79e93103aba760eede71b0
bug 786518 - checkboxes not multiselects