Closed
Bug 786534
Opened 11 years ago
Closed 10 years ago
Remove export target from xpcom/glue Makefiles
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 865673
People
(Reporter: gps, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
5.91 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Various Makefiles under xpcom/glue have export:: targets which do a simple install. These can be rewritten using the generic install rule. Attached is that patch. I don't pretend to understand why these Makefiles are install cpp files into the object directory. That seems wrong to me. But, that's another bug, I reckon. I don't believe this breaks the dependency chain anywhere because, well, I don't think there is a dependency chain other than the order of operations in rules.mk. The install rule runs before the compiler, so we should be good. Try at http://tbpl.mozilla.org/?tree=Try&rev=8aece2a66125
Attachment #656303 -
Flags: review?(khuey)
Attachment #656303 -
Flags: review?(khuey) → review+
Reporter | ||
Comment 1•11 years ago
|
||
I probably should have mentioned that the Try build failed on Windows. Oh, build system.
Comment 3•10 years ago
|
||
Yep
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•