786534 - Remove export target from xpcom/glue Makefiles

Status: RESOLVED DUPLICATE of bug 865673

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Remove export target from xpcom/glue, v1

Various Makefiles under xpcom/glue have export:: targets which do a simple install. These can be rewritten using the generic install rule.

Attached is that patch. I don't pretend to understand why these Makefiles are install cpp files into the object directory. That seems wrong to me. But, that's another bug, I reckon.

I don't believe this breaks the dependency chain anywhere because, well, I don't think there is a dependency chain other than the order of operations in rules.mk. The install rule runs before the compiler, so we should be good.

Try at http://tbpl.mozilla.org/?tree=Try&rev=8aece2a66125

Comment 1

[Gregory Szorc [:gps]]

I probably should have mentioned that the Try build failed on Windows. Oh, build system.

Comment 2

[:Cykesiopka]

Fixed by Bug 865673...?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yep