Closed Bug 786592 Opened 7 years ago Closed 7 years ago

[OS.File] OS.Path.normalize should not log

Categories

(Toolkit :: OS.File, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Yoric, Assigned: avp)

References

Details

Attachments

(1 file, 1 obsolete file)

Line |exports.OS.Shared.LOG("normalize", "stack", stack.toSource());| should just be removed.
Comment on attachment 656389 [details] [diff] [review]
Removed logging of OS.Path.normalize from /osfile/ospath_unix_back.jsm

Review of attachment 656389 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #656389 - Flags: feedback?(dteller) → review+
Assignee: nobody → abhishekp.bugzilla
Should I mark the patch as check-in required ?
Here are the last two steps:
- modify the title of the patch to add ";r=yoric" (without the quotes), as I was the reviewer on this patch;
- add keyword checkin-needed
Thanks Ryan !
https://hg.mozilla.org/mozilla-central/rev/debc0d341e7d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.