786592 - [OS.File] OS.Path.normalize should not log

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Line |exports.OS.Shared.LOG("normalize", "stack", stack.toSource());| should just be removed.

Comment 1

[Abhishek Potnis [:avp]]

Attachment: Removed logging of OS.Path.normalize from /osfile/ospath_unix_back.jsm

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 656389 [details] [diff] [review]
Removed logging of OS.Path.normalize from /osfile/ospath_unix_back.jsm

Review of attachment 656389 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Abhishek Potnis [:avp]]

Should I mark the patch as check-in required ?

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Here are the last two steps:
- modify the title of the patch to add ";r=yoric" (without the quotes), as I was the reviewer on this patch;
- add keyword checkin-needed

Comment 5

[Abhishek Potnis [:avp]]

Attachment: Removed logging of OS.Path.normalize from /osfile/ospath_unix_back.jsm

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Pushed to Try.
https://tbpl.mozilla.org/?tree=Try&rev=e6d648fea6f0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen from comment #6)
> https://tbpl.mozilla.org/?tree=Try&rev=e6d648fea6f0

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/debc0d341e7d

Comment 8

[Abhishek Potnis [:avp]]

Thanks Ryan !

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/debc0d341e7d