If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[console] uriloader must not print to console in opt builds

VERIFIED FIXED in mozilla0.9.3

Status

()

Core
Event Handling
P2
trivial
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: cls, Assigned: Scott MacGregor)

Tracking

Trunk
mozilla0.9.3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>
(Reporter)

Updated

17 years ago
Blocks: 76720
Keywords: mozilla0.9.1
Priority: -- → P2
(Reporter)

Comment 1

17 years ago
Created attachment 33031 [details] [diff] [review]
prelim patch
(Reporter)

Comment 2

17 years ago
Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 3

17 years ago
76720 is targetted for 0.9.1, setting same.
Target Milestone: --- → mozilla0.9.1

Comment 4

17 years ago
moving to 0.9.2.  I have no problem with this making 0.9.1 since it looks like
such an easy fix, but it's not a stopper if it doesn't.
Target Milestone: mozilla0.9.1 → mozilla0.9.2

Comment 5

17 years ago
lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.

Comment 6

17 years ago
moving to 0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3

Comment 7

17 years ago
QA contact updated
QA Contact: gerardok → madhur
(Assignee)

Comment 8

16 years ago
the printf has actually been removed so this patch is no longer necessary. The
uriloader doesn't spew anything to the console now. 
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
verified on build 2001-07-30-10-trunk
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.