78663 - [console] qt port should not print to console in opt builds

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[cls]

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>

Comment 1

[cls]

Attachment: prelim patch

Comment 2

[cls]

Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 3

[John Griggs]

This patch looks fine to me, but the file (nsFontRetrieverService.cpp) is not
currently included in the Qt build, so applying it results in no net change to
the actual application.  If you want, we can apply it anyway to prevent this
issue from coming up again in the future.  Please let me know how you wish to
proceed.

r=[e-mail]

Comment 4

[Jon Granrose]

let's apply it to get it done with.

Comment 5

[chris hofmann]

lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.

Comment 6

[John Griggs]

Adding my home email as a CC, since today is my last day at Corel.

Comment 7

[John C. Griggs]

I'll re-iterate my r=, with my new address:

r=[e-mail]

Comment 8

[John C. Griggs]

I have commited the patch to CVS.

Comment 9

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 10

[Asa Dotzler [:asa]]

so is this fixed?

Comment 11

[John C. Griggs]

I thought I had checked in code that removed the offending printfs already, but 
doulbe-checking today, I find I had not.  This is fixed as of today.

Comment 12

[John C. Griggs]

Patches for this are now in CVS, so I am marking this FIXED.  Please open a new 
bug report for any remaining problems, assigned to [e-mail] (the 
Corel address is no longer valid).

Comment 13

[elaineking]

moved to milestone 0.9.5, 0.9.4 is over.  per pdt mtg.