Last Comment Bug 786714 - TCPSocket is exposing too many interfaces to content
: TCPSocket is exposing too many interfaces to content
Status: RESOLVED FIXED
[mentor=jdm][lang=js]
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla21
Assigned To: Glenna
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-29 09:42 PDT by Josh Matthews [:jdm]
Modified: 2013-02-05 07:31 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (v1) (967 bytes, patch)
2013-02-03 15:36 PST, Glenna
jonas: review+
josh: feedback+
Details | Diff | Splinter Review

Description Josh Matthews [:jdm] 2012-08-29 09:42:09 PDT
TCPSocket's clasSInfo currently has the following:

>    interfaces: [
>      Ci.nsIDOMTCPSocket,
>      Ci.nsIDOMGlobalPropertyInitializer,
>      Ci.nsIObserver,
>      Ci.nsISupportsWeakReference
>    ],

This is unnecessary. We should only be including nsIDOMTCPSocket in that list.
Comment 1 Glenna 2013-02-03 15:28:30 PST
I'll take on this bug.
Comment 2 Glenna 2013-02-03 15:36:01 PST
Created attachment 709534 [details] [diff] [review]
patch (v1)
Comment 3 Josh Matthews [:jdm] 2013-02-04 07:29:41 PST
Comment on attachment 709534 [details] [diff] [review]
patch (v1)

Review of attachment 709534 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Glenna!
Comment 4 Josh Matthews [:jdm] 2013-02-05 02:32:14 PST
Landed with the following modified commit message: "Bug 786714 - Remove unnecessary interfaces from TCPSocket's classinfo. r=sicking"

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5f5d0ef1ff
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-02-05 07:31:27 PST
https://hg.mozilla.org/mozilla-central/rev/4a5f5d0ef1ff

Note You need to log in before you can comment on or make changes to this bug.