TCPSocket is exposing too many interfaces to content

RESOLVED FIXED in mozilla21

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jdm, Assigned: Glenna)

Tracking

unspecified
mozilla21
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jdm][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
TCPSocket's clasSInfo currently has the following:

>    interfaces: [
>      Ci.nsIDOMTCPSocket,
>      Ci.nsIDOMGlobalPropertyInitializer,
>      Ci.nsIObserver,
>      Ci.nsISupportsWeakReference
>    ],

This is unnecessary. We should only be including nsIDOMTCPSocket in that list.
(Reporter)

Updated

5 years ago
Whiteboard: [mentor=jdm][lang=js]
(Assignee)

Comment 1

4 years ago
I'll take on this bug.
(Reporter)

Updated

4 years ago
Assignee: nobody → glennal.buford
(Assignee)

Comment 2

4 years ago
Created attachment 709534 [details] [diff] [review]
patch (v1)
Attachment #709534 - Flags: review?(josh)
(Reporter)

Comment 3

4 years ago
Comment on attachment 709534 [details] [diff] [review]
patch (v1)

Review of attachment 709534 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Glenna!
Attachment #709534 - Flags: review?(josh)
Attachment #709534 - Flags: review?(jonas)
Attachment #709534 - Flags: feedback+
Attachment #709534 - Flags: review?(jonas) → review+
(Reporter)

Comment 4

4 years ago
Landed with the following modified commit message: "Bug 786714 - Remove unnecessary interfaces from TCPSocket's classinfo. r=sicking"

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5f5d0ef1ff
https://hg.mozilla.org/mozilla-central/rev/4a5f5d0ef1ff
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.