Closed
Bug 786714
Opened 13 years ago
Closed 13 years ago
TCPSocket is exposing too many interfaces to content
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jdm, Assigned: glennal.buford)
Details
(Whiteboard: [mentor=jdm][lang=js])
Attachments
(1 file)
|
967 bytes,
patch
|
sicking
:
review+
jdm
:
feedback+
|
Details | Diff | Splinter Review |
TCPSocket's clasSInfo currently has the following:
> interfaces: [
> Ci.nsIDOMTCPSocket,
> Ci.nsIDOMGlobalPropertyInitializer,
> Ci.nsIObserver,
> Ci.nsISupportsWeakReference
> ],
This is unnecessary. We should only be including nsIDOMTCPSocket in that list.
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [mentor=jdm][lang=js]
|
|
Reporter | |
Updated•13 years ago
|
Assignee: nobody → glennal.buford
Attachment #709534 -
Flags: review?(josh)
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 709534 [details] [diff] [review]
patch (v1)
Review of attachment 709534 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Glenna!
Attachment #709534 -
Flags: review?(josh)
Attachment #709534 -
Flags: review?(jonas)
Attachment #709534 -
Flags: feedback+
Attachment #709534 -
Flags: review?(jonas) → review+
|
|
Reporter | |
Comment 4•13 years ago
|
||
Landed with the following modified commit message: "Bug 786714 - Remove unnecessary interfaces from TCPSocket's classinfo. r=sicking"
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a5f5d0ef1ff
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•