Closed Bug 786848 Opened 8 years ago Closed 8 years ago

Need CI script for B2G xpcshell tests

Categories

(Testing :: XPCShell Harness, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: jgriffin, Assigned: mihneadb)

References

Details

Attachments

(1 file, 1 obsolete file)

This script would parse the output of an xpcshell run on B2G, and upload the results to autolog.  

A similar script that handles this for B2G mochitests is here:  https://github.com/jonallengriffin/b2gautomation/blob/master/b2gautomation/mochilog.py
I kept the hardcoded parts as they are in Marionette's post_to_autolog.

Also there are some whitespace fixes.
Attachment #657499 - Flags: feedback?(jgriffin)
Pushed to try to make sure it doesn't break existing xpcshell runs in buildbot:  https://tbpl.mozilla.org/?tree=Try&rev=5183c8314ad2
Comment on attachment 657499 [details] [diff] [review]
post_to_autolog functionality in runxpcshelltests.py

Review of attachment 657499 [details] [diff] [review]:
-----------------------------------------------------------------

In general this looks good.  But there are a couple of things that seem awkward:

- it seems awkward to force code to supply actual and expected results when it has what moztest thinks of as a calculated result.  I think it makes sense to allow moztest to accept a calculated result, in which case it can infer the actual and expected results.
- it seems strange to fake the start and end times.  Many of our test harnesses (for good or bad) just track the test duration, not explicit start and end times.  I think moztest should optionally accept a test duration, rather than forcing it to be a calculation.
Attachment #657499 - Flags: feedback?(jgriffin) → feedback+
Depends on: 788279
Depends on: 788828
This assumes the changes in #788828 have landed.
Attachment #657499 - Attachment is obsolete: true
Attachment #658667 - Flags: review?(jgriffin)
Comment on attachment 658667 [details] [diff] [review]
modify according to feedback

Review of attachment 658667 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks. I'll land after bug 788842.
Attachment #658667 - Flags: review?(jgriffin) → review+
Depends on: 788842
Component: General → XPCShell Harness
Product: Boot2Gecko → Testing
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/1485815e2524
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.