Closed Bug 786979 Opened 12 years ago Closed 11 years ago

Use a new constant for returning ICoreWindow from GetNativeData

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [completed-elm][leave open])

Attachments

(2 files)

patch
2.35 KB, patch
Details | Diff | Splinter Review
mc bits
1.46 KB, patch
bbondy
: review+
Details | Diff | Splinter Review 
In MetroWidget we return the IUnknown ptr from GetNativeData for requests for NS_NATIVE_WINDOW. This request is made from various places in the code base, include accessibility which expects a valid hwnd in the result.

We should define a new native data constant for ICoreWindow and return core window's HWND for NS_NATIVE_WINDOW.

http://mxr.mozilla.org/mozilla-central/search?string=NS_NATIVE_WINDOW
OS: Windows 7 → Windows 8 Metro
Attached patch patch — — Splinter Review 

    
  
Whiteboard: completed-elm

    
    

    
  

      
      
      
      

        Attached patch
          
          
        mc bits
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #659011 -
        Flags: review?(netzen)

        Attachment #659011 -
        Flags: review?(netzen) → review+

    
  
Whiteboard: completed-elm → [completed-elm][leave open]

    
  
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: