787091 - can't save draft if email is digitally signed and contains images

Status: RESOLVED DUPLICATE of bug 1251853

(Thunderbird :: Message Compose Window, defect)

Description

[pasqual milvaques pons]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.81 Safari/537.1

Steps to reproduce:

you compose a mail in html with contains some image with the check mark for digitally signing it activated, you save it and close the compose window. the open it again for edition and try to save it


Actual results:

after that you will see that the image dissapears and only the borders remain, the draft really has not been saved as something internally has gone wrong. if you try to save again in the same window the "saving messages" dialog never ends


Expected results:

the draft must be correctly saved.
this problem only happens with digitally signed drafts and is happening since some versions ago (I don't remember when started). it also happens composing replies (then happens when you save the draft for the first time).
this is very annoying if you have autosave activated

Comment 1

[Thomas D. (:thomas8)]

pasqual, can you try this:

For affected message, try saving as draft *without* digital signing. Bug still occurs?

Can you reproduce this bug:
- with recent release version TB15?
- with current Trunk of TB?

I suspect this is caused by problems with inline images, and we've got a number of bugs for that.

Comment 2

[pasqual milvaques pons]

without digital signing all is OK

with TB15 the bug reproduces

with TB16b2 from here:
https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/16.0b2-candidates/build1/linux-x86_64/ca/

also reproduces

best regards

Comment 3

[Thomas D. (:thomas8)]

(In reply to pasqual.milvaques from comment #2)
> without digital signing all is OK

pasqual, thanks for speedy reply, that's helpful.

I should have been more explicit in my question:
- For a mail with digital signing AND images that initially *fails* to save,
- then if you only uncheck digital signing but keep the images
- then save as draft
-> does the bug still occur?

Pls attach source of affected msg from draft folder that uses digital signature AND images and fails to save when reopened and manually saved.
Remove private data as required, then "Add an attachment" at the top of this bug.
Also add the certificate if possible.

Comment 4

[pasqual milvaques pons]

the problem is that when the saving of the draft fails it breaks the images so only the borders appear in the draft, posterior attempts to save the draft make the saving dialog to stay forever. unchecking digital signing doesn't changes the results, the images keeps broken.
if after all this you take a look to the drafts folder you can see that the draft have not really been saved, keeps the version that existed before the crashing

I attach an image of the draft when it crashes the image

best regards

Comment 5

[pasqual milvaques pons]

Attachment: crashed draft

Comment 6

[Thomas D. (:thomas8)]

(In reply to pasqual.milvaques from comment #4)
> the problem is that when the saving of the draft fails it breaks the images
> so only the borders appear in the draft, posterior attempts to save the
> draft make the saving dialog to stay forever. unchecking digital signing
> doesn't changes the results, the images keeps broken.
> if after all this you take a look to the drafts folder you can see that the
> draft have not really been saved, keeps the version that existed before the
> crashing

pasqual, I understand from your comment 4 that your testcase that failed with digital signing AND images will still fail when digital signing is unchecked (switched off) - i.e. we have a failure for a msg with images (but without digital signing). I conclude that digital signing is not relevant for reproduction of this bug.

To confirm, can you pls test the following:
- enable (switch ON) digital signing
- ensure that msg has *NO* images whatsoever
- send
That works correctly, right?

Can you pls attach the source code of an affected draft (the saved version from drafts folder before the crash) that fails?

Comment 7

[pasqual milvaques pons]

the testcase only fails when digital signing is checked. I tried to say that when the image is crashed as shown in the image the act of unchecking digital signing doesn't help to solve the problem

saving and sending mails when there are not images works correctly with digital signing.  

I attach the sorce code

Comment 8

[pasqual milvaques pons]

Attachment: sorce code of the draft from the drafts folder

Comment 9

[Jorg K (CEST = GMT+2)]

I'm making this a forward duplicate of bug 1251853 since that bug has more analysis.