787162 - Sort by rating is broken

Status: VERIFIED FIXED

(Marketplace Graveyard :: Search, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/search/?price=&cat=&sort=rating
2. Check if the apps are sorted by rating

observed behavior:
Looks like sort=rating is not being honored.

Comment 1

[Rob Hudson [:robhudson]]

Mine looks a lot different. Did we re-indexing after the db refresh?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Rob Hudson [:robhudson] from comment #1)
> Mine looks a lot different. Did we re-indexing after the db refresh?

I did, yeah. I think the cron's messed up.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Also note that "1 Ratings" should be "1 Rating"

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #3)
> Also note that "1 Ratings" should be "1 Rating"

Disregard that.

How old is that screenshot? Because I don't see that anymore (I fixed it in bug 787711). And the design in the screenshot is quite different than it is today.

Still a bug though, yes.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/164918b

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/6d34881

Comment 7

[Victor Carciu]

Verified as fixed.

Comment 8

[Victor Carciu]

Attachment: Postfix screenshot

Comment 9

[Victor Carciu]

Sort by rating is not working as expected again(Not yet rated apps displayed before rated apps). See attached screenshot.

Comment 10

[Victor Carciu]

Attachment: Ratings broken again

Comment 11

[Christopher Van Wiemeersch [:cvan]]

Andy fixed our indexing in bug 819486. And this should be fixed going forward. Thanks for catching this!

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified, thx