Plugin block doesn't have severity attribute

VERIFIED FIXED in 2012-09-06

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P1
blocker
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: jorgev, Assigned: wraithan)

Tracking

unspecified
2012-09-06
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 657044 [details]
Blocklist.xml from staging

These two blocks have their severity set to 0:

https://addons-dev.allizom.org/en-US/admin/models/blocklist/blocklistdetail/125/
https://addons-dev.allizom.org/en-US/admin/models/blocklist/blocklistdetail/127/

However, the blocklist.xml being downloaded has this:

<pluginItem  blockID="p125">
  <match name="name" exp="Java\(TM\) Platform SE 7 U[5-6](\s[^\d\._U]|$)" />
  <match name="filename" exp="npjp2\.dll" />
</pluginItem>
      
<pluginItem  blockID="p127">
  <match name="name" exp="Java\(TM\) Plug-in 1\.7\.0(_0?([5-6]))?([^\d\._]|$)" />
  <match name="filename" exp="libnpjp2\.so" />
</pluginItem>

They are missing a node like this one:
<versionRange  severity="0"></versionRange>

It looks like this works when severity is set to 1 (see blockID="p121").

Comment 1

6 years ago
I think severity="0" is the default value and hence it's not downloaded to lower the required bandwidth.
Assignee: nobody → xwraithanx
Target Milestone: 2012-08-30 → 2012-09-06
(Reporter)

Comment 2

6 years ago
As requested, here are the details for block 125:

= General section =

Name:
Java Plugin

Why:
(a bunch of text)

Who:
All Firefox users on Windows and Linux who have installed Java 7.

= Plugin section =

Name:
Java\(TM\) Platform SE 7 U[5-6](\s[^\d\._U]|$)

Filename:
npjp2\.dll

Severity:
0
(Assignee)

Updated

6 years ago
Blocks: 778365
We need to test this very carefully... for add-ons we use block severity 0 because it omits the severity (making the XML file smaller) and an omitted severity means a hard block (normally severity 3).

So if we change it such that severity 0 actually displays, we may affected all our hardblocked add-ons.
Justin, please let us know if there is something QA can help test overnight. I've CC'd Ioana, one of our Softvision testers in Romania. Ioana, please coordinate any testing Justin requires. Otherwise, we'll have to pick this up tomorrow morning when I come back online.
(Reporter)

Comment 5

6 years ago
Wraithan, it'd be good to make a diff of the blocklist before and after the change, to see which other blocks are affected by it.

Also note that I asked him only to push it to -dev today since we only need it for QA. The push to prod can be done tomorrow.
https://github.com/mozilla/zamboni/commit/263c899e

Sorry I had internet issues for a bit took me a bit to be able to . This is not code reviewed but passes tests with 0'd severity. Dev should auto deploy but I'll mention it in channel to someone.

Comment 7

6 years ago
I've tested this on Firefox 15.0 - tested the Java plugin blocks and soft and hard blocks for add-on (Real Player Browser Plugin and Timeline Kapat). Everything worked fine.
Forgot to resolve this last night. Doing so now.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 9

6 years ago
I think this went out last week
Status: RESOLVED → VERIFIED
(In reply to krupa raj 82[:krupa] from comment #9)
> I think this went out last week

Nope, not yet.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.