Copy-optimize the IPC *Channels

RESOLVED WORKSFORME

Status

()

Core
IPC
RESOLVED WORKSFORME
6 years ago
3 years ago

People

(Reporter: cjones, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:-)

Details

(Whiteboard: [tech-p3])

Right now, we're a bit more careless than we should be about copying Messages in ipc/glue, which may have a few KB or up payloads.  We should have 0 copies from SendFoo() --> write to socket, and we should have exactly one copy in OnMessageReceived() --> RecvFoo().

Comment 1

6 years ago
not blocking, right?
blocking-basecamp: --- → ?
Not a blocker based on comments #1 and #2.
blocking-basecamp: ? → -
My gut says there's probably not a lot of win here, but there are certainly degenerate cases where we're suffering, and I could be wrong and it's something we should do.
Whiteboard: [tech-p3]
I think we've taken care of this with bug 1092010 and bug 1062713 (and possibly others).  At least from a quick grepping through Recv/Send stuff, I couldn't see any more copies than suggested in comment 0.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.